feat: DVC-9059 pull out EnvironmentConfigManager to its own library, change nodejs build to define external pacakges #564

jonathannorris · 2023-09-26T18:40:54Z

Update NodeJS build process to bundle libraries that are not defined in the package.json / external under the build step.
Pull out EnvironmentConfigManager into a generic lib to be used by the Edge Worker SDK
Other libs like the server request handling will be pulled into libs with further stacked PRs.

vercel · 2023-09-26T18:40:55Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
js-sdks-next-js	❌ Failed (Inspect)			Oct 24, 2023 7:29pm
js-sdks-web-elements	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2023 7:29pm
js-sdks-with-provider	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2023 7:29pm

jonathannorris · 2023-09-26T18:41:04Z

Current dependencies on/for this PR:

main
- PR feat: DVC-9055 extract JS Cloud Bucketing SDK from NodeJS SDK #560
  - PR feat: DVC-9055 adding Cloudflare Worker example app for new js-cloud-server-sdk #561
    - PR feat: DVC-9059 pull out EnvironmentConfigManager to its own library, change nodejs build to define external pacakges #564 👈
      - PR feat: DVC9059 move core server request logic to new lib #565
        
        PR feat: setup new EdgeWorker SDK with cloud and local bucketing #566

This comment was auto-generated by Graphite.

sdk/nodejs/project.json

ajwootto · 2023-09-27T21:50:12Z

lib/shared/config-manager/src/index.ts

    private readonly cdnURI: string
    fetchConfigPromise: Promise<void>
-    private intervalTimeout?: NodeJS.Timeout
+    private intervalTimeout?: any


why does this need to be any?

basically because NodeJS.Timeout isn't supported in webworker / browser environments, they just return a number I believe. So the strategy here was to add a setInterval + clearInterval interface that would be passed in, so this needs to be an Any if we want it to compile when used in the non-NodeJS SDKs.

if you wanted to get fancy you could use a type generic for this. Type it so that the generic is what is returned by the SetIntervalInterface and then use the same generic here.

ajwootto · 2023-09-27T21:51:22Z

lib/shared/config-manager/src/index.ts

        logger: DVCLogger,
        sdkKey: string,
+        setConfigBuffer: SetConfigBuffer,
+        setInterval: SetIntervalInterface,


this polling config fetcher seems very specific to the nodejs local bucketing SDK, what purpose would it serve in the worker SDK other than to fetch it once?

workers do last for a while (I think I've seen 10's of minutes if not longer), we'd still want polling for them.

lib/shared/config-manager/project.json

…dejs build to define external pacakges

This was referenced Sep 26, 2023

feat: DVC-9055 extract JS Cloud Bucketing SDK from NodeJS SDK #560

Merged

feat: DVC-9055 adding Cloudflare Worker example app for new js-cloud-server-sdk #561

Merged

vercel bot deployed to Preview – js-sdks-web-elements September 26, 2023 18:45 View deployment

vercel bot deployed to Preview – js-sdks-with-provider September 26, 2023 18:48 View deployment

vercel bot deployed to Preview – js-sdks-next-js September 26, 2023 18:49 View deployment

vercel bot deployed to Preview – js-sdks-with-provider September 26, 2023 19:32 View deployment

vercel bot deployed to Preview – js-sdks-web-elements September 26, 2023 19:32 View deployment

vercel bot deployed to Preview – js-sdks-next-js September 26, 2023 19:33 View deployment

vercel bot deployed to Preview – js-sdks-with-provider September 26, 2023 19:47 View deployment

vercel bot deployed to Preview – js-sdks-web-elements September 26, 2023 19:47 View deployment

vercel bot deployed to Preview – js-sdks-next-js September 26, 2023 19:48 View deployment

jonathannorris requested review from a team and ajwootto September 26, 2023 20:54

jonathannorris marked this pull request as ready for review September 26, 2023 20:54

gitstream-cm bot added the 20 min review label Sep 26, 2023

jonathannorris force-pushed the DVC-9055-add-cf-example-app branch from f669994 to 5351674 Compare September 26, 2023 21:13

jonathannorris force-pushed the DVC-9059-add-bundled-libraries branch from 4493435 to 51b013c Compare September 26, 2023 21:13

jonathannorris mentioned this pull request Sep 26, 2023

feat: DVC9059 move core server request logic to new lib #565

Merged

jonathannorris changed the title ~~feat: pull out EnvironmentConfigManager to its own library, change nodejs build to define external pacakges~~ feat: DVC-9059 pull out EnvironmentConfigManager to its own library, change nodejs build to define external pacakges Sep 26, 2023

vercel bot deployed to Preview – js-sdks-next-js September 26, 2023 21:27 View deployment

vercel bot deployed to Preview – js-sdks-with-provider September 26, 2023 21:27 View deployment

vercel bot deployed to Preview – js-sdks-web-elements September 26, 2023 21:27 View deployment

jonathannorris mentioned this pull request Sep 27, 2023

feat: setup new EdgeWorker SDK with cloud and local bucketing #566

Draft

ajwootto reviewed Sep 27, 2023

View reviewed changes

sdk/nodejs/project.json Outdated Show resolved Hide resolved

ajwootto reviewed Sep 27, 2023

View reviewed changes

jonathannorris force-pushed the DVC-9055-add-cf-example-app branch from 5351674 to 6ae5b9f Compare September 29, 2023 15:41

jonathannorris force-pushed the DVC-9059-add-bundled-libraries branch from ed1fb2d to d811b17 Compare September 29, 2023 15:55

ajwootto reviewed Oct 23, 2023

View reviewed changes

lib/shared/config-manager/project.json Show resolved Hide resolved

jonathannorris force-pushed the DVC-9059-add-bundled-libraries branch from 07fe21a to 9c8e5dd Compare October 23, 2023 20:50

vercel bot deployed to Preview – js-sdks-with-provider October 23, 2023 20:56 View deployment

vercel bot deployed to Preview – js-sdks-web-elements October 23, 2023 20:57 View deployment

ajwootto approved these changes Oct 23, 2023

View reviewed changes

vercel bot deployed to Preview – js-sdks-with-provider October 23, 2023 21:02 View deployment

vercel bot deployed to Preview – js-sdks-web-elements October 23, 2023 21:04 View deployment

vercel bot deployed to Preview – js-sdks-next-js October 23, 2023 21:06 View deployment

jonathannorris force-pushed the DVC-9059-add-bundled-libraries branch from adc5edf to 3ec54d0 Compare October 24, 2023 17:51

vercel bot had a problem deploying to Preview – js-sdks-next-js October 24, 2023 18:02 Failure

vercel bot deployed to Preview – js-sdks-web-elements October 24, 2023 18:06 View deployment

vercel bot deployed to Preview – js-sdks-with-provider October 24, 2023 18:07 View deployment

jonathannorris added 11 commits October 24, 2023 14:54

feat: pull out EnvironmentConfigManager to its own library, change no…

092a1bb

…dejs build to define external pacakges

fix: update tests, move environmentConfigManager tests

2479d31

fix: remove environmentConfigManger.ts file

b077ddf

fix: cleanup getEnvironmentConfig from nodejs, move tests

b5d5260

fix: update README.md

74243cc

fix: add missing fetch-retry dep to nodejs

a67c3c7

fix: add shared-bucketing-as to node externals

9beb4d6

fix: prettier

74f7de1

fix: add temp UserError

21600ee

fix: remove build step from config-manager

04cd75a

fix: add build step back

d2cf865

jonathannorris force-pushed the DVC-9059-add-bundled-libraries branch from 3ec54d0 to d2cf865 Compare October 24, 2023 19:12

jonathannorris enabled auto-merge (squash) October 24, 2023 19:12

vercel bot had a problem deploying to Preview – js-sdks-next-js October 24, 2023 19:16 Failure

vercel bot deployed to Preview – js-sdks-with-provider October 24, 2023 19:29 View deployment

vercel bot deployed to Preview – js-sdks-web-elements October 24, 2023 19:29 View deployment

jonathannorris merged commit 94334bd into main Oct 24, 2023

jonathannorris deleted the DVC-9059-add-bundled-libraries branch October 24, 2023 19:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: DVC-9059 pull out EnvironmentConfigManager to its own library, change nodejs build to define external pacakges #564

feat: DVC-9059 pull out EnvironmentConfigManager to its own library, change nodejs build to define external pacakges #564

Uh oh!

jonathannorris commented Sep 26, 2023 •

edited

Loading

Uh oh!

vercel bot commented Sep 26, 2023 •

edited

Loading

Uh oh!

jonathannorris commented Sep 26, 2023 •

edited

Loading

Uh oh!

Uh oh!

ajwootto Sep 27, 2023

Uh oh!

jonathannorris Sep 28, 2023

Uh oh!

ajwootto Oct 2, 2023

Uh oh!

ajwootto Sep 27, 2023

Uh oh!

jonathannorris Sep 28, 2023

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

feat: DVC-9059 pull out EnvironmentConfigManager to its own library, change nodejs build to define external pacakges #564

feat: DVC-9059 pull out EnvironmentConfigManager to its own library, change nodejs build to define external pacakges #564

Uh oh!

Conversation

jonathannorris commented Sep 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Sep 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonathannorris commented Sep 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ajwootto Sep 27, 2023

Choose a reason for hiding this comment

Uh oh!

jonathannorris Sep 28, 2023

Choose a reason for hiding this comment

Uh oh!

ajwootto Oct 2, 2023

Choose a reason for hiding this comment

Uh oh!

ajwootto Sep 27, 2023

Choose a reason for hiding this comment

Uh oh!

jonathannorris Sep 28, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

jonathannorris commented Sep 26, 2023 •

edited

Loading

vercel bot commented Sep 26, 2023 •

edited

Loading

jonathannorris commented Sep 26, 2023 •

edited

Loading