Skip to content

Commit 51b013c

Browse files
fix: cleanup getEnvironmentConfig from nodejs, move tests
1 parent d7cd6d5 commit 51b013c

File tree

4 files changed

+1
-23
lines changed

4 files changed

+1
-23
lines changed

sdk/nodejs/__tests__/request.spec.ts renamed to lib/shared/config-manager/__tests__/request.spec.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,9 @@ import fetch, { Response } from 'cross-fetch'
33

44
global.fetch = fetch
55

6+
import { getEnvironmentConfig } from '../src/request'
67
const fetchRequestMock = fetch as jest.MockedFn<typeof fetch>
78

8-
import { publishEvents, getEnvironmentConfig } from '../src/request'
9-
import { dvcDefaultLogger } from '@devcycle/js-cloud-server-sdk'
10-
const logger = dvcDefaultLogger()
11-
129
describe('request.ts Unit Tests', () => {
1310
beforeEach(() => {
1411
fetchRequestMock.mockReset()

sdk/nodejs/src/request.ts

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -6,25 +6,6 @@ export const HOST = '.devcycle.com'
66
export const EVENT_URL = 'https://events'
77
export const EVENTS_PATH = '/v1/events/batch'
88

9-
export async function getEnvironmentConfig(
10-
url: string,
11-
requestTimeout: number,
12-
etag?: string,
13-
): Promise<Response> {
14-
const headers: Record<string, string> = etag
15-
? { 'If-None-Match': etag }
16-
: {}
17-
18-
return await getWithTimeout(
19-
url,
20-
{
21-
headers: headers,
22-
retries: 1,
23-
},
24-
requestTimeout,
25-
)
26-
}
27-
289
export async function publishEvents(
2910
logger: DVCLogger,
3011
sdkKey: string,

0 commit comments

Comments
 (0)