feat: DVC-9055 extract JS Cloud Bucketing SDK from NodeJS SDK #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
jonathannorris
changed the title
chris-hoefgen
approved these changes
Sep 20, 2023
ajwootto
reviewed
Sep 21, 2023
ajwootto
reviewed
Sep 21, 2023
ajwootto
reviewed
Sep 21, 2023
ajwootto
reviewed
Sep 21, 2023
ajwootto
reviewed
Sep 21, 2023
ajwootto
reviewed
Sep 21, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| fetchRequestMock.mockResolvedValue( | ||
| new Response('', { status: 200 }), | ||
| ) | ||
| await post('https://test.com', {}, 'token') |
Check failure
Code scanning / CodeQL
Hard-coded credentials
| expect.objectContaining({ | ||
| method: 'POST', | ||
| headers: { | ||
| Authorization: 'token', |
Check failure
Code scanning / CodeQL
Hard-coded credentials
| new Response('', { status: 500 }), | ||
| ) | ||
| await expect( | ||
| post('https://test.com', {}, 'token'), |
Check failure
Code scanning / CodeQL
Hard-coded credentials
| expect.objectContaining({ | ||
| method: 'POST', | ||
| headers: { | ||
| Authorization: 'token', |
Check failure
Code scanning / CodeQL
Hard-coded credentials
ajwootto
reviewed
Oct 2, 2023
ajwootto
approved these changes
Oct 2, 2023
jonathannorris
force-pushed
the
DVC-9055-extract-cloud-sdk
branch
from
b598042 to
1ed12da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting the JS Cloud Bucketing SDK from the NodeJS SDK, this will allow for the more generic JS Cloud Bucketing SDK to be used in places where the NodeJS SDK couldn't be (Cloudflare Workers / Edge Worker Runtimes / Electron Apps / etc). The NodeJS SDK will import this new SDK for its existing
DevCycleCloudClientinterface. To avoid duplication of code, most of the shared logic from the NodeJS SDK has been moved to the new JS Cloud Bucketing SDK and imported from there.