feat: DVC-9055 adding Cloudflare Worker example app for new js-cloud-server-sdk #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
jonathannorris
changed the title
jonathannorris
changed the title
JamieSinn
reviewed
Sep 20, 2023
JamieSinn
reviewed
Sep 21, 2023
Comment on lines
37
to
40
| RESPONSE=$(curl -s http://localhost:8787) # Replace with your server's port | ||
| # Check the response or do something based on the result. | ||
| if [[ "$RESPONSE" != *"DevCycle Variables:"* ]]; then | ||
| echo "Server didn't return the expected 'DevCycle Variables:' response" | ||
| exit 1 | ||
| fi |
Member
There was a problem hiding this comment.
Suggested change
| RESPONSE=$(curl -s http://localhost:8787) # Replace with your server's port | |
| # Check the response or do something based on the result. | |
| if [[ "$RESPONSE" != *"DevCycle Variables:"* ]]; then | |
| echo "Server didn't return the expected 'DevCycle Variables:' response" | |
| exit 1 | |
| fi | |
| RESPONSE=$(curl -s http://localhost:8787) | |
| if [[ "$RESPONSE" != *"DevCycle Variables:"* ]]; then | |
| echo "Server didn't return the expected 'DevCycle Variables:' response" | |
| exit 1 | |
| fi |
Member
There was a problem hiding this comment.
Also - would you not want to do more clear sanitizing and checks via jq?
Member
Author
There was a problem hiding this comment.
we can, I'm more interested in if it actually returns anything and doesn't throw a worker error, which this checks for.
JamieSinn
reviewed
Sep 21, 2023
Comment on lines
37
to
40
| RESPONSE=$(curl -s http://localhost:8787) # Replace with your server's port | ||
| # Check the response or do something based on the result. | ||
| if [[ "$RESPONSE" != *"DevCycle Variables:"* ]]; then | ||
| echo "Server didn't return the expected 'DevCycle Variables:' response" | ||
| exit 1 | ||
| fi |
Member
There was a problem hiding this comment.
Also - would you not want to do more clear sanitizing and checks via jq?
Comment on lines
6
to
21
| "target": "es2021" /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */, | ||
| "lib": ["es2021"] /* Specify a set of bundled library declaration files that describe the target runtime environment. */, | ||
| "jsx": "react" /* Specify what JSX code is generated. */, | ||
| "module": "es2022" /* Specify what module code is generated. */, | ||
| "moduleResolution": "node" /* Specify how TypeScript looks up a file from a given module specifier. */, | ||
| "types": ["@cloudflare/workers-types"] /* Specify type package names to be included without being referenced in a source file. */, | ||
| "resolveJsonModule": true /* Enable importing .json files */, | ||
| "allowJs": true /* Allow JavaScript files to be a part of your program. Use the `checkJS` option to get errors from these files. */, | ||
| "checkJs": false /* Enable error reporting in type-checked JavaScript files. */, | ||
| "noEmit": true /* Disable emitting files from a compilation. */, | ||
| "isolatedModules": true /* Ensure that each file can be safely transpiled without relying on other imports. */, | ||
| "allowSyntheticDefaultImports": true /* Allow 'import x from y' when a module doesn't have a default export. */, | ||
| "forceConsistentCasingInFileNames": true /* Ensure that casing is correct in imports. */, | ||
|
|
||
| "strict": true /* Enable all strict type-checking options. */, | ||
| "skipLibCheck": true /* Skip type checking all .d.ts files. */ |
Contributor
There was a problem hiding this comment.
Why not comments? It's actually kinda nice having an explanation for each setting.
I'm assuming this is one of those flavors of JSON that allows comments, like the VS Code config files.
Member
Author
There was a problem hiding this comment.
These comments were all from the example app I generated using Cloudflare's CLI.
Member
There was a problem hiding this comment.
We should do that for our cli too
Member
There was a problem hiding this comment.
We should do that for our cli too, and maybe the sdk proxy too
rob-odwyer
reviewed
Sep 21, 2023
jonathannorris
force-pushed
the
DVC-9055-add-cf-example-app
branch
from
581c1ea to
596e031
Compare
jonathannorris
force-pushed
the
DVC-9055-add-cf-example-app
branch
from
a65390f to
e57af12
Compare
jonathannorris
force-pushed
the
DVC-9055-add-cf-example-app
branch
from
4f3188b to
65c293b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.