IAT: Reinstate early bailout #148771
Open
IAT: Reinstate early bailout #148771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmease
added
F-inherent_associated_types
rustbot
added
the
S-waiting-on-review
Collaborator
|
|
fmease
force-pushed
the
iat-reinstate-early-elim
branch
from
f35de59 to
129c7f0
Compare
fmease
commented
Nov 9, 2025
| Some(InherentAssocCandidate { impl_, assoc_item: item.def_id, scope }) | ||
| }) | ||
| .collect(); | ||
|
|
Member
Author
There was a problem hiding this comment.
Obviously this is but a hotfix for a minute part of #142006. I was briefly toying with the idea of properly addressing #142006 now but for that I would need to rewrite type-relative path resolution in HIR ty lowering to properly assemble inherent & trait candidates (instead of eagerly trying to resolve them in sequence) but I realized I would only be stepping on your toes / doing throwaway work (#145825).
fmease
commented
Nov 9, 2025
Member
Author
There was a problem hiding this comment.
I wrote this test and it's rooted in a deep misconception, namely that there can't ever be a case where we would pick a trait candidate over an inherent one. Back then I didn't know about #142006.
In essence, I don't like this test, hence its removal. Once we fix #142006, we'll have plenty of tests regarding "candidate preference/elimination".
fmease
force-pushed
the
iat-reinstate-early-elim
branch
from
129c7f0 to
a9fd741
Compare
fmease
force-pushed
the
iat-reinstate-early-elim
branch
from
a9fd741 to
6ed469c
Compare
fmease
changed the title
Member
|
@bors r+ lgtm. i thought i'd get around to fixing type relative path lowering sooner than it seems like I actually am going to be so this seems reasonable for the time being |
Collaborator
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 10, 2025
…=BoxyUwU IAT: Reinstate early bailout Apparently, some people are already using IATs in their projects and get blocked by rust-lang#142006 (comment) (cc dupes rust-lang#143952 & rust-lang#148535). Since the (temporary) fix is so trivial, let's just do it. Addresses rust-lang#142006 (comment). cc `@luissantosHCIT` (rust-lang#148535). r? `@BoxyUwU`
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 10, 2025
…=BoxyUwU IAT: Reinstate early bailout Apparently, some people are already using IATs in their projects and get blocked by rust-lang#142006 (comment) (cc dupes rust-lang#143952 & rust-lang#148535). Since the (temporary) fix is so trivial, let's just do it. Addresses rust-lang#142006 (comment). cc ``@luissantosHCIT`` (rust-lang#148535). r? ``@BoxyUwU``
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 11, 2025
…=BoxyUwU IAT: Reinstate early bailout Apparently, some people are already using IATs in their projects and get blocked by rust-lang#142006 (comment) (cc dupes rust-lang#143952 & rust-lang#148535). Since the (temporary) fix is so trivial, let's just do it. Addresses rust-lang#142006 (comment). cc ``@luissantosHCIT`` (rust-lang#148535). r? ``@BoxyUwU``
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 11, 2025
…=BoxyUwU IAT: Reinstate early bailout Apparently, some people are already using IATs in their projects and get blocked by rust-lang#142006 (comment) (cc dupes rust-lang#143952 & rust-lang#148535). Since the (temporary) fix is so trivial, let's just do it. Addresses rust-lang#142006 (comment). cc ```@luissantosHCIT``` (rust-lang#148535). r? ```@BoxyUwU```
bors
added a commit
that referenced
this pull request
Nov 11, 2025
Rollup of 13 pull requests Successful merges: - #148694 (std: support `RwLock` and thread parking on TEEOS) - #148712 (Port `cfg_select!` to the new attribute parsing system) - #148760 (rustc_target: hide TargetOptions::vendor) - #148771 (IAT: Reinstate early bailout) - #148775 (Fix a typo in the documentation for the strict_shr function) - #148779 (Implement DynSend and DynSync for std::panic::Location.) - #148781 ([rustdoc] Remove unneeded `allow(rustc::potential_query_instability)`) - #148783 (add test for assoc type norm wf check) - #148785 (Replace `master` branch references with `main`) - #148791 (fix "is_closure_like" doc comment) - #148792 (Prefer to use file.stable_id over file.name from source map) - #148805 (rustc-dev-guide subtree update) - #148807 (Document (and test) a problem with `Clone`/`Copy` deriving.) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, some people are already using IATs in their projects and get blocked by #142006 (comment) (cc dupes #143952 & #148535). Since the (temporary) fix is so trivial, let's just do it.
Addresses #142006 (comment).
cc @luissantosHCIT (#148535).
r? @BoxyUwU