Skip to content

Conversation

@Zalathar
Copy link
Member

@Zalathar Zalathar commented Nov 11, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

aDotInTheVoid and others added 30 commits November 5, 2025 18:11
>  We continuously rebuild the latest versions for all crates so they can benefit from new features in rustdoc. 

-- https://docs.rs/releases/queue
sembr some rustdoc files and improve them a bit
This fixes some code block tags that aren't using the correct language
for rust.
This was incorrectly interpreting the value as an HTML tag. This wraps
it in an code span to avoid that.
…loadllvm

the download-ci-llvm experiment turned out to be too unreliable
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
This updates the rust-version file to 8401398.
Pull recent changes from https://github.com/rust-lang/rust via Josh.

Upstream ref: 8401398
Filtered ref: 52a911b7100ca6a6ed84159c51ce514a98ae9cf5
Upstream diff: rust-lang/rust@c5dabe8...8401398

This merge was created using https://github.com/rust-lang/josh-sync.
…, r=saethlin

Document (and test) a problem with `Clone`/`Copy` deriving.

I think this is useful information. I have worked on `derive` impls quite a bit and didn't know about this issue until today.

r? `@saethlin`
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) rollup A PR which is a rollup labels Nov 11, 2025
@Zalathar
Copy link
Member Author

Rollup of everything not in #148817.

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Nov 11, 2025

📌 Commit 224ff38 has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2025
@Zalathar
Copy link
Member Author

@bors try jobs=x86_64-msvc-1,i686-msvc-1,x86_64-mingw-1,test-various,armhf-gnu,aarch64-apple

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Nov 11, 2025
Rollup of 13 pull requests

try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
try-job: test-various
try-job: armhf-gnu
try-job: aarch64-apple
@rust-bors
Copy link

rust-bors bot commented Nov 11, 2025

☀️ Try build successful (CI)
Build commit: 3e45a3b (3e45a3b34c4c746f2f72c2b87ed044d9c00bd827, parent: c8f22ca269a1f2653ac962fe2bc21105065fd6cd)

@bors
Copy link
Collaborator

bors commented Nov 11, 2025

⌛ Testing commit 224ff38 with merge 2636cb4...

@bors
Copy link
Collaborator

bors commented Nov 11, 2025

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 2636cb4 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 11, 2025
@bors bors merged commit 2636cb4 into rust-lang:main Nov 11, 2025
13 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 11, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 9312cd6 (parent) -> 2636cb4 (this PR)

Test differences

Show 26 test diffs

Stage 1

  • [ui] tests/ui/associated-inherent-types/fall-back-to-trait-candidate.rs: [missing] -> pass (J0)
  • [ui] tests/ui/associated-inherent-types/not-found-self-type-differs-shadowing-trait-item.rs#shadowed: pass -> [missing] (J0)
  • [ui] tests/ui/associated-inherent-types/not-found-self-type-differs-shadowing-trait-item.rs#uncovered: pass -> [missing] (J0)
  • [ui] tests/ui/associated-inherent-types/prefer-inherent-over-trait.rs: [missing] -> pass (J0)
  • [ui] tests/ui/generic-associated-types/must-prove-where-clauses-on-norm.rs#current: [missing] -> pass (J0)
  • [ui] tests/ui/generic-associated-types/must-prove-where-clauses-on-norm.rs#next: [missing] -> pass (J0)

Stage 2

  • [ui] tests/ui/associated-inherent-types/fall-back-to-trait-candidate.rs: [missing] -> pass (J1)
  • [ui] tests/ui/associated-inherent-types/not-found-self-type-differs-shadowing-trait-item.rs#shadowed: pass -> [missing] (J1)
  • [ui] tests/ui/associated-inherent-types/not-found-self-type-differs-shadowing-trait-item.rs#uncovered: pass -> [missing] (J1)
  • [ui] tests/ui/associated-inherent-types/prefer-inherent-over-trait.rs: [missing] -> pass (J1)
  • [ui] tests/ui/generic-associated-types/must-prove-where-clauses-on-norm.rs#current: [missing] -> pass (J1)
  • [ui] tests/ui/generic-associated-types/must-prove-where-clauses-on-norm.rs#next: [missing] -> pass (J1)

Additionally, 14 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2636cb4c1328f5a3ab05b8d13a666ac5f3a48a08 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 1485.4s -> 1892.7s (+27.4%)
  2. x86_64-rust-for-linux: 2614.0s -> 3243.1s (+24.1%)
  3. x86_64-gnu-llvm-20: 2473.3s -> 2869.3s (+16.0%)
  4. x86_64-gnu-tools: 3309.5s -> 3787.4s (+14.4%)
  5. aarch64-gnu-debug: 4091.1s -> 4669.4s (+14.1%)
  6. x86_64-gnu-gcc: 3053.9s -> 3454.1s (+13.1%)
  7. x86_64-gnu-miri: 4354.5s -> 4922.2s (+13.0%)
  8. i686-gnu-2: 5672.2s -> 6407.9s (+13.0%)
  9. i686-gnu-nopt-1: 7268.9s -> 8184.4s (+12.6%)
  10. arm-android: 5829.0s -> 6494.4s (+11.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#148694 std: support RwLock and thread parking on TEEOS 9040dc782446e1d3d5d903c827e1c9ddf9ac5491 (link)
#148712 Port cfg_select! to the new attribute parsing system b73c235daa5269723a90698a46ce40921e738447 (link)
#148760 rustc_target: hide TargetOptions::vendor fb684b3aafbd18e89444def44ab78e9ceb0c05b4 (link)
#148771 IAT: Reinstate early bailout 7d9229270bb3fbc9df2b361935fe73a3bb69bd5c (link)
#148775 Fix a typo in the documentation for the strict_shr function 9580dae23c3cfb31c5eb923537d3f1c1c9e847dd (link)
#148779 Implement DynSend and DynSync for std::panic::Location. 66ba6bc0dafad67f57ec48764554d27de9e59a1d (link)
#148781 [rustdoc] Remove unneeded `allow(rustc::potential_query_ins… ba2212f702ed32cc8b4c1084ce80a6f0cec37e97 (link)
#148783 add test for assoc type norm wf check 811e7679e8d0e60409aac489c7f940727f756fb6 (link)
#148785 Replace master branch references with main 9682ed8161f3595b248e9a95ce0cbcfde9007471 (link)
#148791 fix "is_closure_like" doc comment f67278af36939cb0a683b0d8cf02318bc593e125 (link)
#148792 Prefer to use file.stable_id over file.name from source map ee3db7850af1d4449078858de5f0cbcf4174f6e0 (link)
#148805 rustc-dev-guide subtree update 2ccbac22e12b765b6b0039ba9287a85af1ad91e4 (link)
#148807 Document (and test) a problem with Clone/Copy deriving. 4b56c58dc4015810eff143779be9ec092e1b9ba2 (link)

previous master: 9312cd6d38

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2636cb4): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.8% [-1.8%, -1.8%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.8% [-1.8%, -1.8%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 477.625s -> 478.438s (0.17%)
Artifact size: 391.41 MiB -> 391.34 MiB (-0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.