Skip to content

CORS-4280: AWS: Add throughput validation for gp3 volumes #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CORS-4280: AWS: Add throughput validation for gp3 volumes #1430

wants to merge 2 commits into from
+130 −0

Conversation

@jhixson74
Copy link
Member

@jhixson74 jhixson74 commented Nov 7, 2025

Throughput can only be configured on gp3 volumes and must be between 125 and 2000 MiB's

This pull request depends on openshift/api#2480

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 7, 2025 •
edited by openshift-ci bot
Loading

@jhixson74: This pull request references CORS-4280 which is a valid jira issue.

In response to this:

Throughput can only be configured on gp3 volumes and must be between 125 and 2000 MiB's

This pull request depends on openshift/api#2480

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from nrb and racheljpg November 7, 2025 00:50
This was referenced Nov 7, 2025
Open
Open
@damdo damdo mentioned this pull request Nov 13, 2025
Open
@damdo
Copy link
Member

damdo commented Nov 13, 2025

/assign @JoelSpeed @damdo

damdo
damdo reviewed Nov 13, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/hold

For other reviews and in case you want to address my personal preference

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2025
@damdo
Copy link
Member

damdo commented Nov 13, 2025

/test unit

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 13, 2025
@jhixson74 jhixson74 force-pushed the main_aws_gp3_throughput branch from bc526a8 to 710235e Compare November 14, 2025 04:26
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2025

@jhixson74: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 710235e link true /test e2e-aws-ovn
ci/prow/okd-scos-images 710235e link true /test okd-scos-images
ci/prow/e2e-aws-ovn-upgrade 710235e link true /test e2e-aws-ovn-upgrade
ci/prow/golint 710235e link true /test golint
ci/prow/govet 710235e link true /test govet
ci/prow/images 710235e link true /test images
ci/prow/e2e-aws-operator 710235e link true /test e2e-aws-operator
ci/prow/e2e-metal-ipi-ovn-ipv6 710235e link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/unit 710235e link true /test unit
ci/prow/e2e-metal-ipi-virtualmedia 710235e link true /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi 710235e link true /test e2e-metal-ipi
ci/prow/okd-scos-e2e-aws-ovn 710235e link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jhixson74 jhixson74 requested a review from damdo November 15, 2025 00:48
@damdo
Copy link
Member

damdo commented Nov 15, 2025

@jhixson74 Needs rebasing

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 15, 2025

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nrb nrb Awaiting requested review from nrb

@racheljpg racheljpg Awaiting requested review from racheljpg

@damdo damdo Awaiting requested review from damdo

Assignees

@damdo damdo

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jhixson74 @openshift-ci-robot @damdo @openshift-merge-robot @JoelSpeed