AWS: GP3 volume throughput tests

Author: jhixson74

pkg/webhooks/machine_webhook_test.go

@@ -451,6 +451,110 @@ func TestMachineCreation(t *testing.T) {
 			},
 			expectedError: "admission webhook \"validation.machine.machine.openshift.io\" denied the request: spec.hostPlacement.dedicatedHost.id: Invalid value: \"invalid\": id must start with 'h-' followed by 17 lowercase hexadecimal characters (0-9 and a-f)",
 		},
+		{
+			name:         "with VolumeType set to gp3 and Throughput not set",
+			platformType: osconfigv1.AWSPlatformType,
+			clusterID:    "aws-cluster",
+			providerSpecValue: &kruntime.RawExtension{
+				Object: &machinev1beta1.AWSMachineProviderConfig{
+					AMI: machinev1beta1.AWSResourceReference{
+						ID: ptr.To[string]("ami"),
+					},
+					BlockDevices: []machinev1beta1.BlockDeviceMappingSpec{
+						{
+							EBS: &machinev1beta1.EBSBlockDeviceSpec{
+								VolumeType: ptr.To[string]("gp3"),
+							},
+						},
+					},
+				},
+			},
+			expectedError: "",
+		},
+		{
+			name:         "with VolumeType set to gp3 and Throughput set under minium value",
+			platformType: osconfigv1.AWSPlatformType,
+			clusterID:    "aws-cluster",
+			providerSpecValue: &kruntime.RawExtension{
+				Object: &machinev1beta1.AWSMachineProviderConfig{
+					AMI: machinev1beta1.AWSResourceReference{
+						ID: ptr.To[string]("ami"),
+					},
+					BlockDevices: []machinev1beta1.BlockDeviceMappingSpec{
+						{
+							EBS: &machinev1beta1.EBSBlockDeviceSpec{
+								VolumeType:    ptr.To[string]("gp3"),
+								ThroughputMib: ptr.To[int32](124),
+							},
+						},
+					},
+				},
+			},
+			expectedError: "providerSpec.blockDevices[0].ebs.throughputMib must be a value between 125 and 2000",
+		},
+		{
+			name:         "with VolumeType set to gp3 and Throughput set over maxium value",
+			platformType: osconfigv1.AWSPlatformType,
+			clusterID:    "aws-cluster",
+			providerSpecValue: &kruntime.RawExtension{
+				Object: &machinev1beta1.AWSMachineProviderConfig{
+					AMI: machinev1beta1.AWSResourceReference{
+						ID: ptr.To[string]("ami"),
+					},
+					BlockDevices: []machinev1beta1.BlockDeviceMappingSpec{
+						{
+							EBS: &machinev1beta1.EBSBlockDeviceSpec{
+								VolumeType:    ptr.To[string]("gp3"),
+								ThroughputMib: ptr.To[int32](2001),
+							},
+						},
+					},
+				},
+			},
+			expectedError: "providerSpec.blockDevices[0].ebs.throughputMib must be a value between 125 and 2000",
+		},
+		{
+			name:         "with VolumeType set to gp3 and Throughput set within range",
+			platformType: osconfigv1.AWSPlatformType,
+			clusterID:    "aws-cluster",
+			providerSpecValue: &kruntime.RawExtension{
+				Object: &machinev1beta1.AWSMachineProviderConfig{
+					AMI: machinev1beta1.AWSResourceReference{
+						ID: ptr.To[string]("ami"),
+					},
+					BlockDevices: []machinev1beta1.BlockDeviceMappingSpec{
+						{
+							EBS: &machinev1beta1.EBSBlockDeviceSpec{
+								VolumeType:    ptr.To[string]("gp3"),
+								ThroughputMib: ptr.To[int32](1000),
+							},
+						},
+					},
+				},
+			},
+			expectedError: "",
+		},
+		{
+			name:         "with Throughput set on non gp3 volume",
+			platformType: osconfigv1.AWSPlatformType,
+			clusterID:    "aws-cluster",
+			providerSpecValue: &kruntime.RawExtension{
+				Object: &machinev1beta1.AWSMachineProviderConfig{
+					AMI: machinev1beta1.AWSResourceReference{
+						ID: ptr.To[string]("ami"),
+					},
+					BlockDevices: []machinev1beta1.BlockDeviceMappingSpec{
+						{
+							EBS: &machinev1beta1.EBSBlockDeviceSpec{
+								VolumeType:    ptr.To[string]("io1"),
+								ThroughputMib: ptr.To[int32](124),
+							},
+						},
+					},
+				},
+			},
+			expectedError: "providerSpec.blockDevices[0].ebs.throughputMib is only valid for gp3 volumes",
+		},
 		{
 			name:              "with Azure and a nil provider spec value",
 			platformType:      osconfigv1.AzurePlatformType,