Skip to content

fix(getSkyBlockProfiles): fetching garden & museum while either are disabled #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −2
Open

fix(getSkyBlockProfiles): fetching garden & museum while either are disabled #684

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09b6bc2
fix: museum and garden options
BridgeSenseDev Nov 18, 2025
b2347d9
pnpm lint
BridgeSenseDev Nov 18, 2025
c09f77d
only fetch when options explicitly set to true
BridgeSenseDev Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/API/getSkyBlockProfiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ class getSkyBlockProfiles extends Endpoint {
if (!res.data.profiles || !res.data.profiles.length) throw new Error(Errors.NO_SKYBLOCK_PROFILES);
const profiles: Map<SkyBlockProfileName | 'UNKNOWN', SkyBlockProfile> = new Map();
for (const profile of res.data.profiles) {
const garden = await this.handleGettingSkyBlockGarden(profile.profile_id);
const museum = await this.handleGettingSkyBlockMuseum(profile.profile_id);
const garden = options?.garden !== false ? await this.handleGettingSkyBlockGarden(profile.profile_id) : null;
const museum = options?.museum !== false ? await this.handleGettingSkyBlockMuseum(profile.profile_id) : null;
const parsedProfile = new SkyBlockProfile(profile, { uuid: query, garden, museum });
profiles.set(parsedProfile.profileName, parsedProfile);
}
Expand Down
Loading