Skip to content

fix(getSkyBlockProfiles): fetching garden & museum while either are disabled #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 20, 2025
+4 −4
Merged

fix(getSkyBlockProfiles): fetching garden & museum while either are disabled #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5b932b9
fix: museum and garden options
BridgeSenseDev Nov 18, 2025
81ce1f0
pnpm lint
BridgeSenseDev Nov 18, 2025
1a2cfc8
only fetch when options explicitly set to true
BridgeSenseDev Nov 20, 2025
5d556cf
simplify ternary
BridgeSenseDev Nov 20, 2025
42c74e3
also respect options in fetchSkyblockProfile
BridgeSenseDev Nov 20, 2025
aa314b4
fix(getSkyBlockProfile/s): garden & museum types
Kathund Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/API/getSkyBlockProfile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ class getSkyBlockProfile extends Endpoint {
const res = await this.client.requestHandler.request(`/skyblock/profile?profile=${profileId}`, options);
if (res.options.raw) return res;
if (!res.data.profile) throw new Error(Errors.NO_SKYBLOCK_PROFILES);
const garden = await this.handleGettingSkyBlockGarden(res.data.profile.profile_id);
const museum = await this.handleGettingSkyBlockMuseum(res.data.profile.profile_id);
const garden = options?.museum ? await this.handleGettingSkyBlockGarden(res.data.profile.profile_id) : undefined;
const museum = options?.museum ? await this.handleGettingSkyBlockMuseum(res.data.profile.profile_id) : undefined;
const parsedProfile = new SkyBlockProfile(res.data.profile, { uuid: null, garden, museum });
return parsedProfile;
}
Expand Down
4 changes: 2 additions & 2 deletions src/API/getSkyBlockProfiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ class getSkyBlockProfiles extends Endpoint {
if (!res.data.profiles || !res.data.profiles.length) throw new Error(Errors.NO_SKYBLOCK_PROFILES);
const profiles: Map<SkyBlockProfileName | 'UNKNOWN', SkyBlockProfile> = new Map();
for (const profile of res.data.profiles) {
const garden = await this.handleGettingSkyBlockGarden(profile.profile_id);
const museum = await this.handleGettingSkyBlockMuseum(profile.profile_id);
const garden = options?.garden ? await this.handleGettingSkyBlockGarden(profile.profile_id) : undefined;
const museum = options?.museum ? await this.handleGettingSkyBlockMuseum(profile.profile_id) : undefined;
const parsedProfile = new SkyBlockProfile(profile, { uuid: query, garden, museum });
profiles.set(parsedProfile.profileName, parsedProfile);
}
Expand Down
Loading