Skip to content

Conversation

@BridgeSenseDev
Copy link
Contributor

Changes

Fixed getSkyBlockProfiles to not fetch skyblock museum and garden depending on whether garden or museum options is false:

const profiles = await hypixel
  .getSkyBlockProfiles("uuid", {
    garden: false,
    museum: false,
  });

Previously it would fetch museum and garden even when false.

Screenshots
Checkboxes
  • I've added new features. (methods or parameters)
  • I've fixed bug. (optional you can mention a issue if there is one)
  • I've corrected the spelling in README, documentation, etc.
  • I've tested my code. (pnpm test)
  • I've check for issues. (pnpm lint)
  • I've fixed my formatting. (pnpm prettier)

Comment on lines +22 to +23
const garden = options?.garden !== false ? await this.handleGettingSkyBlockGarden(profile.profile_id) : null;
const museum = options?.museum !== false ? await this.handleGettingSkyBlockMuseum(profile.profile_id) : null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const garden = options?.garden !== false ? await this.handleGettingSkyBlockGarden(profile.profile_id) : null;
const museum = options?.museum !== false ? await this.handleGettingSkyBlockMuseum(profile.profile_id) : null;
const garden = options?.garden === true ? await this.handleGettingSkyBlockGarden(profile.profile_id) : null;
const museum = options?.museum === true ? await this.handleGettingSkyBlockMuseum(profile.profile_id) : null;

@Kathund Kathund changed the title fix: museum and garden options fix(getSkyBlockProfiles): fetching garden & museum while either are disabled Nov 19, 2025
@Kathund Kathund enabled auto-merge (squash) November 19, 2025 05:08
Copy link
Member

@Kathund Kathund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seams like it's also an issue in getSkyBlockProfile

const garden = await this.handleGettingSkyBlockGarden(res.data.profile.profile_id);
const museum = await this.handleGettingSkyBlockMuseum(res.data.profile.profile_id);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants