feat: DVC-9055 extract JS Cloud Bucketing SDK from NodeJS SDK (#560)

Author: jonathannorris

package.json

@@ -66,6 +66,7 @@
     "devDependencies": {
         "@babel/core": "^7.17.7",
         "@babel/preset-react": "^7.14.5",
+        "@cloudflare/workers-types": "^4.20230914.0",
         "@commitlint/cli": "^16.2.3",
         "@commitlint/config-conventional": "^16.2.1",
         "@nrwl/js": "16.3.2",

sdk/js-cloud-server/.babelrc

@@ -0,0 +1,10 @@
+{
+    "presets": [
+        [
+            "@nx/js/babel",
+            {
+                "useBuiltIns": "usage"
+            }
+        ]
+    ]
+}

sdk/js-cloud-server/.eslintrc.json

@@ -0,0 +1,18 @@
+{
+    "extends": ["../../.eslintrc.json"],
+    "ignorePatterns": ["!**/*", "node_modules/*", "src/pb-types/compiled*"],
+    "overrides": [
+        {
+            "files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
+            "rules": {}
+        },
+        {
+            "files": ["*.ts", "*.tsx"],
+            "rules": {}
+        },
+        {
+            "files": ["*.js", "*.jsx"],
+            "rules": {}
+        }
+    ]
+}

sdk/js-cloud-server/.gitignore

@@ -0,0 +1,4 @@
+built/*
+dist/*
+node_modules/*
+.npmrc

sdk/js-cloud-server/README.md

@@ -0,0 +1,19 @@
+# DevCycle Javascript Cloud Bucketing Server SDK
+
+This SDK is used to integrate DevCycle with your Javascript server-side application, where a NodeJS runtime isn't available.
+Example use-cases would be Cloudflare Workers and other edge-worker runtimes.
+
+This SDK makes API requests to DevCycle's [Bucketing API](https://docs.devcycle.com/bucketing-api/) to perform bucketing.
+See our [System Architecture Documentation](https://docs.devcycle.com/introduction/architecture#cloud-bucketing-server-sdk-architecture) for more details.
+
+### Installation
+
+Our library can be found on npm and installed by the following:
+
+```
+npm install @devcycle/js-cloud-server-sdk"
+```
+
+### Usage
+
+To find usage documentation, visit our [docs](https://docs.devcycle.com/docs/sdk/server-side-sdks/node#usage).

sdk/js-cloud-server/__mocks__/cross-fetch.ts

@@ -0,0 +1,6 @@
+const { Request, Response } = jest.requireActual('cross-fetch')
+
+const fetch = jest.fn()
+
+export { Request, Response }
+export default fetch

sdk/js-cloud-server/__mocks__/fetch-retry.ts

@@ -0,0 +1,2 @@
+export const fetchWithRetry = (_fetch: unknown): unknown => _fetch
+export default fetchWithRetry

sdk/nodejs/__tests__/cloudClient.spec.ts renamed to sdk/js-cloud-server/__tests__/cloudClient.spec.ts

@@ -21,7 +21,6 @@ describe('DevCycleCloudClient without EdgeDB', () => {
     beforeAll(async () => {
         client = DVC.initializeDevCycle('dvc_server_token', {
             logLevel: 'error',
-            enableCloudBucketing: true,
         })
         server.listen()
     })
@@ -246,7 +245,6 @@ describe('DevCycleCloudClient with EdgeDB Enabled', () => {
     beforeAll(async () => {
         client = DVC.initializeDevCycle('dvc_server_token', {
             logLevel: 'error',
-            enableCloudBucketing: true,
             enableEdgeDB: true,
         })
         server.listen()

sdk/js-cloud-server/__tests__/initialize.spec.ts

@@ -0,0 +1,24 @@
+import { DevCycleCloudClient, initializeDevCycle } from '../src/index'
+
+describe('JS Cloud Bucketing Server SDK Initialize', () => {
+    afterAll(() => {
+        jest.clearAllMocks()
+    })
+
+    it('successfully calls initialize with no options', async () => {
+        const client = initializeDevCycle('dvc_server_token')
+        expect(client).toBeDefined()
+    })
+
+    it('fails to initialize when no token is provided', () => {
+        expect(() =>
+            initializeDevCycle(undefined as unknown as string),
+        ).toThrow('Missing SDK key! Call initialize with a valid SDK key')
+    })
+
+    it('fails to initialize when client token is provided', () => {
+        expect(() => initializeDevCycle('dvc_client_token')).toThrow(
+            'Invalid SDK key provided. Please call initialize with a valid server SDK key',
+        )
+    })
+})

sdk/nodejs/__tests__/models/populatedUser.spec.ts renamed to sdk/js-cloud-server/__tests__/models/populatedUser.spec.ts

@@ -3,17 +3,20 @@ import { DevCycleUser } from '../../src/models/user'
 
 describe('DVCPopulatedUser Unit Tests', () => {
     it('should construct DVCPopulatedUser from UserParam', () => {
-        const requestUser = new DVCPopulatedUser({
-            user_id: 'user_id',
-            email: 'email',
-            name: 'name',
-            language: 'en',
-            country: 'ca',
-            appVersion: 'appVersion',
-            appBuild: 1,
-            customData: { custom: 'data' },
-            privateCustomData: { private: 'customData' },
-        })
+        const requestUser = new DVCPopulatedUser(
+            {
+                user_id: 'user_id',
+                email: 'email',
+                name: 'name',
+                language: 'en',
+                country: 'ca',
+                appVersion: 'appVersion',
+                appBuild: 1,
+                customData: { custom: 'data' },
+                privateCustomData: { private: 'customData' },
+            },
+            {},
+        )
         expect(requestUser).toEqual(
             expect.objectContaining({
                 user_id: 'user_id',
@@ -47,7 +50,7 @@ describe('DVCPopulatedUser Unit Tests', () => {
             customData: { custom: 'data' },
             privateCustomData: { private: 'customData' },
         })
-        const populatedUser = DVCPopulatedUser.fromDVCUser(requestUser)
+        const populatedUser = DVCPopulatedUser.fromDVCUser(requestUser, {})
         expect(populatedUser).toEqual(
             expect.objectContaining({
                 user_id: 'user_id',