Fix tamper sensor showing for wrong Frient entry sensors #4491
Conversation
TheJulianJES
added
bugfix
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4491 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 369 369
Lines 12094 12096 +2
=======================================
+ Hits 11156 11158 +2
Misses 938 938 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhaquirks/develco/open_close.py
Outdated
| .applies_to("Develco Products A/S", "WISZB-121") | ||
| .applies_to("frient A/S", "WISZB-121") |
There was a problem hiding this comment.
In Zigbee2MQTT, WISZB-121 (basic Entry Sensor, 1st Gen) supports the tamper sensor, but according to specsheet, it doesn't: https://cdn.prod.website-files.com/67f4edb3e49fc9eedd4d58ff/68627bf514b30153d4133678_Entry%20sensor_frient_v1.0.pdf
There was a problem hiding this comment.
deCONZ seems to support tamper for the basic sensor (1st Gen) as well: https://github.com/dresden-elektronik/deconz-rest-plugin/blob/41d9a4933f45b6d14fbc96b9df0f8524ffb66c4c/devices/frient/wiszb-121_open_close_sensor.json#L111-L114
I'll adjust this PR to only remove the tamper sensor for the 2nd Gen Pro sensor then.
It would be good to get confirmation on this though 😄
There was a problem hiding this comment.
Let me check the device itself, I might have one. Every one I added explicitly should have tamper sensor support.
2 participants
Proposed change
This fixes an issue where the binary tamper sensor is shown for the Frient Entry Sensor 2 Pro and Entry Sensor (basic) which both do not support the tamper sensor according to specifications.
It's only supported by the 1st Gen Frient Entry Sensor Pro.
Additional information
Follow-up to:
Device diagnostics
Should already be in ZHA diagnostics. I don't have the devices anyway.
Checklist
pre-commitchecks pass / the code has been formatted using Black