Skip to content

Fix tamper sensor showing for wrong Frient entry sensors #4491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

Fix tamper sensor showing for wrong Frient entry sensors #4491

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a100c5f
Remove tamper sensor for Frient Entry Sensor (basic) and Entry Sensor…
TheJulianJES Nov 14, 2025
839da4d
Re-enable tamper sensor for basic sensor
TheJulianJES Nov 17, 2025
a2c784d
Apply pre-commit auto fixes
pre-commit-ci[bot] Nov 17, 2025
75bc49a
Skip formatting for quirk
TheJulianJES Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions zhaquirks/develco/open_close.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,28 @@ class DevelcoPowerConfiguration(PowerConfigurationCluster):
MAX_VOLTS = 3.0


(
QuirkBuilder("frient A/S", "WISZB-131")
.applies_to("Develco Products A/S", "WISZB-120")
.applies_to("frient A/S", "WISZB-120")
.applies_to("Develco Products A/S", "WISZB-121")
.applies_to("frient A/S", "WISZB-121")
base_quirk = (
QuirkBuilder()
.replaces(DevelcoIasZone, endpoint_id=35)
.replaces(DevelcoPowerConfiguration, endpoint_id=35)
# The binary input cluster is a duplicate
.prevent_default_entity_creation(endpoint_id=35, cluster_id=BinaryInput.cluster_id)
)

# Entry Sensor 2 Pro + Entry Sensor (basic), no tamper
(
base_quirk.clone()
.applies_to("frient A/S", "WISZB-131")
.applies_to("Develco Products A/S", "WISZB-121")
.applies_to("frient A/S", "WISZB-121")
Copy link
Collaborator Author

@TheJulianJES TheJulianJES Nov 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Zigbee2MQTT, WISZB-121 (basic Entry Sensor, 1st Gen) supports the tamper sensor, but according to specsheet, it doesn't: https://cdn.prod.website-files.com/67f4edb3e49fc9eedd4d58ff/68627bf514b30153d4133678_Entry%20sensor_frient_v1.0.pdf

Copy link
Collaborator Author

@TheJulianJES TheJulianJES Nov 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deCONZ seems to support tamper for the basic sensor (1st Gen) as well: https://github.com/dresden-elektronik/deconz-rest-plugin/blob/41d9a4933f45b6d14fbc96b9df0f8524ffb66c4c/devices/frient/wiszb-121_open_close_sensor.json#L111-L114

I'll adjust this PR to only remove the tamper sensor for the 2nd Gen Pro sensor then.
It would be good to get confirmation on this though 😄

Copy link
Contributor

@puddly puddly Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check the device itself, I might have one. Every one I added explicitly should have tamper sensor support.

.add_to_registry()
)

# Entry Sensor Pro, with tamper
(
base_quirk.clone()
.applies_to("Develco Products A/S", "WISZB-120")
.applies_to("frient A/S", "WISZB-120")
.binary_sensor(
endpoint_id=35,
cluster_id=IasZone.cluster_id,
Expand Down
Loading