Skip to content

Decrease YDB CPU consumption in docker and some tests #27759 #28405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Decrease YDB CPU consumption in docker and some tests #27759 #28405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,6 @@ EXPOSE ${GRPC_PORT:-2136}
EXPOSE ${MON_PORT:-8765}
EXPOSE ${YDB_KAFKA_PROXY_PORT:-9092}

HEALTHCHECK --start-period=60s --interval=1s CMD sh /health_check
HEALTHCHECK --start-period=60s --interval=60s CMD sh /health_check
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The healthcheck interval change from 1s to 60s significantly reduces overhead but increases the time to detect container failures from 1 second to 60 seconds. Consider if this detection latency is acceptable for your deployment scenarios, or use an intermediate value (e.g., 10-30s) to balance CPU usage with failure detection speed.

Suggested change
HEALTHCHECK --start-period=60s --interval=60s CMD sh /health_check
HEALTHCHECK --start-period=60s --interval=15s CMD sh /health_check

Copilot uses AI. Check for mistakes.

CMD ["sh", "/initialize_local_ydb"]
2 changes: 1 addition & 1 deletion ydb/tests/library/harness/resources/default_yaml.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ actor_system_config:
name: "IC"
time_per_mailbox_micro_secs: 100
scheduler:
resolution: 256
resolution: 1024
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increasing the scheduler resolution from 256 to 1024 microseconds reduces scheduling frequency but may impact latency-sensitive operations. Ensure this 4x increase in resolution doesn't adversely affect test timing accuracy or responsiveness requirements, particularly for tests that rely on precise timing.

Suggested change
resolution: 1024
resolution: 256

Copilot uses AI. Check for mistakes.
spin_threshold: 0
progress_threshold: 10000
sys_executor: 0
Expand Down
Loading