Skip to content

Conversation

@eivanov89
Copy link
Member

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reduces YDB CPU consumption in Docker environments and tests by adjusting timing-related configuration parameters.

  • Increased scheduler resolution from 256 to 1024 microseconds in test harness configuration
  • Changed Docker healthcheck interval from 1 second to 60 seconds

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
ydb/tests/library/harness/resources/default_yaml.yml Increases scheduler resolution to reduce CPU overhead during tests
.github/docker/Dockerfile Reduces healthcheck frequency to lower CPU consumption in Docker containers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

time_per_mailbox_micro_secs: 100
scheduler:
resolution: 256
resolution: 1024
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increasing the scheduler resolution from 256 to 1024 microseconds reduces scheduling frequency but may impact latency-sensitive operations. Ensure this 4x increase in resolution doesn't adversely affect test timing accuracy or responsiveness requirements, particularly for tests that rely on precise timing.

Suggested change
resolution: 1024
resolution: 256

Copilot uses AI. Check for mistakes.
EXPOSE ${YDB_KAFKA_PROXY_PORT:-9092}

HEALTHCHECK --start-period=60s --interval=1s CMD sh /health_check
HEALTHCHECK --start-period=60s --interval=60s CMD sh /health_check
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The healthcheck interval change from 1s to 60s significantly reduces overhead but increases the time to detect container failures from 1 second to 60 seconds. Consider if this detection latency is acceptable for your deployment scenarios, or use an intermediate value (e.g., 10-30s) to balance CPU usage with failure detection speed.

Suggested change
HEALTHCHECK --start-period=60s --interval=60s CMD sh /health_check
HEALTHCHECK --start-period=60s --interval=15s CMD sh /health_check

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

🟢 2025-11-07 15:53:02 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

2025-11-07 15:53:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for b4dc3f9 has started.
2025-11-07 15:54:11 UTC Artifacts will be uploaded here
2025-11-07 15:56:33 UTC ya make is running...
🟡 2025-11-07 16:41:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
7206 7056 0 3 131 16

2025-11-07 16:42:04 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-07 16:48:55 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
35 (only retried tests) 24 0 0 0 11

🟢 2025-11-07 16:49:04 UTC Build successful.
🟢 2025-11-07 16:49:22 UTC ydbd size 2.3 GiB changed* by +3.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8705cd5 merge: b4dc3f9 diff diff %
ydbd size 2 431 794 744 Bytes 2 431 798 576 Bytes +3.7 KiB +0.000%
ydbd stripped size 516 527 664 Bytes 516 528 624 Bytes +960 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

2025-11-07 15:53:55 UTC Pre-commit check linux-x86_64-release-asan for b4dc3f9 has started.
2025-11-07 15:54:13 UTC Artifacts will be uploaded here
2025-11-07 15:56:29 UTC ya make is running...
🟡 2025-11-07 17:02:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3216 3005 0 40 157 14

🟢 2025-11-07 17:02:16 UTC Build successful.
🟢 2025-11-07 17:02:39 UTC ydbd size 3.8 GiB changed* by +19.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 45828a5 merge: b4dc3f9 diff diff %
ydbd size 4 072 956 144 Bytes 4 072 976 200 Bytes +19.6 KiB +0.000%
ydbd stripped size 1 511 824 456 Bytes 1 511 834 056 Bytes +9.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant