g2o: update to 2024.12.28

[choyy]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @choyy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the g2o package to its latest version, 2024.12.28. Alongside this update, it refines the build process by introducing a specific version constraint for the eigen dependency and implementing a conditional logic to select the appropriate C++ standard (C++14 or C++17) based on the g2o package version. These changes aim to maintain compatibility, leverage newer language features where beneficial, and ensure a robust build environment for the g2o library.

Highlights

• G2O Version Update: The g2o package has been updated to version 2024.12.28, incorporating the latest changes and improvements from the upstream repository.
• Eigen Dependency Constraint: A version constraint has been added for the eigen dependency, specifically requiring a version less than 5.0 to ensure compatibility with the updated g2o package.
• Conditional C++ Standard Selection: The C++ standard used for building g2o is now dynamically determined based on its version. Packages with a version of 2023.08.06 or newer will be built with C++17, while older versions will continue to use C++14.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the g2o package to a new version. It also pins the eigen dependency to versions older than 5.0 and updates the required C++ standard for newer g2o versions. My review found a critical issue with the new version string 2024.12.28, which appears to be invalid and will likely cause the package installation to fail. Please see the detailed comment for more information.

[gemini-code-assist]

The version string "2024.12.28" does not correspond to a valid tag or commit in the g2o repository (https://github.com/RainerKuemmerle/g2o/tags). This will cause the package to fail during source fetching. Please use a valid tag. For example, the latest tag is 2023.08.07. You will also need to update the SHA256 hash accordingly if you change the version.