refactor: replace subprocess calls with run_example_module helper #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like the actual change is missing? In any case, usually it's better to rebase the commit on top of main instead of merging |
Contributor
Author
|
What is missing? I think that I can see all the files. |
Contributor
|
Nevermind - I think github UI hasn't updated correctly, so I wasn't seeing the complete changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the test for the
hello_esp32example to improve code reuse and maintainability by introducing a utility function for running example modules. The main change is the extraction of subprocess logic into a shared helper, which simplifies the test and centralises environment handling.