-
Notifications
You must be signed in to change notification settings - Fork 55
feat: get monitors pagination #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
dpelengic
wants to merge
2
commits into
winor30:main
from
dpelengic:feat/monitor-list-pagination-complete
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -4,7 +4,37 @@ export const GetMonitorsZodSchema = z.object({ | |||||||
| groupStates: z | ||||||||
| .array(z.enum(['alert', 'warn', 'no data', 'ok'])) | ||||||||
| .optional() | ||||||||
| .describe('Filter monitors by their states'), | ||||||||
| name: z.string().optional().describe('Filter monitors by name'), | ||||||||
| tags: z.array(z.string()).optional().describe('Filter monitors by tags'), | ||||||||
| .describe( | ||||||||
| 'Filter monitors by their states (e.g., alert, warn, no data, ok)', | ||||||||
| ), | ||||||||
| name: z | ||||||||
| .string() | ||||||||
| .optional() | ||||||||
| .describe('Filter monitors by name (case-sensitive)'), | ||||||||
| tags: z | ||||||||
| .array(z.string()) | ||||||||
| .optional() | ||||||||
| .describe('Filter monitors by tags (e.g., ["env:prod", "service:api"])'), | ||||||||
| idOffset: z | ||||||||
| .number() | ||||||||
| .int() | ||||||||
| .optional() | ||||||||
| .describe( | ||||||||
| 'Start listing from this monitor ID. Use with pageSize=1 to get a specific monitor. For pagination, use the last monitor ID from previous response.', | ||||||||
| ), | ||||||||
| page: z | ||||||||
| .number() | ||||||||
| .int() | ||||||||
| .optional() | ||||||||
| .describe( | ||||||||
| 'Page number for pagination (0-based). Use with pageSize parameter.', | ||||||||
| ), | ||||||||
| pageSize: z | ||||||||
| .number() | ||||||||
| .int() | ||||||||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| .optional() | ||||||||
| .default(100) | ||||||||
| .describe( | ||||||||
| 'Number of monitors per page (default: 100). Set to 1 with idOffset to get a specific monitor.', | ||||||||
| ), | ||||||||
| }) | ||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,14 +23,16 @@ export const createMonitorsToolHandlers = ( | |
| ): MonitorsToolHandlers => { | ||
| return { | ||
| get_monitors: async (request) => { | ||
| const { groupStates, name, tags } = GetMonitorsZodSchema.parse( | ||
| request.params.arguments, | ||
| ) | ||
| const { groupStates, name, tags, idOffset, page, pageSize } = | ||
| GetMonitorsZodSchema.parse(request.params.arguments) | ||
|
|
||
| const response = await apiInstance.listMonitors({ | ||
| groupStates: groupStates?.join(','), | ||
| name, | ||
| tags: tags?.join(','), | ||
| page, | ||
| pageSize, | ||
| idOffset, | ||
| }) | ||
|
|
||
| if (response == null) { | ||
|
|
@@ -105,6 +107,14 @@ export const createMonitorsToolHandlers = ( | |
| type: 'text', | ||
| text: `Summary of monitors: ${JSON.stringify(summary)}`, | ||
| }, | ||
| ...(monitors.length > 0 | ||
| ? [ | ||
| { | ||
| type: 'text', | ||
| text: `Last monitor ID: ${monitors[monitors.length - 1].id}`, | ||
| }, | ||
| ] | ||
| : []), | ||
|
Comment on lines
+110
to
+117
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i think these logic can be more simplified monitors.length > 0 && {
type: 'text',
text: `Last monitor ID:
${monitors[monitors.length - 1].id}`
} |
||
| ], | ||
| } | ||
| }, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it is better