feat: get monitors pagination #34
Closed
+133
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dragan Pelengić <dp@MacBook-Pro.local>
Signed-off-by: Dragan Pelengic <46516779+dpelengic@users.noreply.github.com>
winor30
reviewed
Jun 4, 2025
Owner
winor30
left a comment
winor30
left a comment
There was a problem hiding this comment.
thank you for your contribution!
i reviewd some comments. but almost lgtm
Comment on lines
+110
to
+117
| ...(monitors.length > 0 | ||
| ? [ | ||
| { | ||
| type: 'text', | ||
| text: `Last monitor ID: ${monitors[monitors.length - 1].id}`, | ||
| }, | ||
| ] | ||
| : []), |
Owner
There was a problem hiding this comment.
i think these logic can be more simplified
monitors.length > 0 && {
type: 'text',
text: `Last monitor ID:
${monitors[monitors.length - 1].id}`
}| ), | ||
| page: z | ||
| .number() | ||
| .int() |
Owner
There was a problem hiding this comment.
i think it is better
Suggested change
| .int() | |
| .int() | |
| .min(0) |
| ), | ||
| pageSize: z | ||
| .number() | ||
| .int() |
Owner
There was a problem hiding this comment.
Suggested change
| .int() | |
| .int() | |
| .positive() |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
+ Coverage 89.66% 89.98% +0.32%
==========================================
Files 32 32
Lines 1238 1278 +40
Branches 153 155 +2
==========================================
+ Hits 1110 1150 +40
Misses 128 128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pagination capabilities to the
get_monitorstool for more efficient monitor listing and specific monitor retrieval.Changes
idOffset: Start listing from a specific monitor IDpage: Page number (0-based)pageSize: Number of monitors per page (default: 100)Use Cases
pageandpageSizeidOffsetidOffsetwithpageSize=1All changes maintain backward compatibility and follow existing test patterns.