Skip to content

Upgrade to web-features 3.6.0 #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade to web-features 3.6.0 #1216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 25 additions & 15 deletions scripts/identify-web-features.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,15 @@ const argv = yargs(process.argv)

const octokit = new Octokit({ auth: process.env.GITHUB_TOKEN });

function getFeature(id) {
const feature = features[id];
if (!feature || feature.kind !== "feature") {
Copy link
Member

@foolip foolip Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you see any benefit from handling moved features? It could be done by returning [id, data] perhaps, so that callers that use the ID could use the new one.

return null;
}

return feature;
}

function escapeFeatureName(feature) {
// Escape the feature name for use in HTML.
return feature.name.replace(/</g, "&lt;").replace(/>/g, "&gt;");
Expand All @@ -45,8 +54,12 @@ function gatherFeaturesFromSpecUrls(urls) {

for (const url of urls) {
for (const id in features) {
const feature = features[id];
const specUrls = (Array.isArray(feature.spec) ? feature.spec : [feature.spec]).map(url => new URL(url));
const feature = getFeature(id);
if (!feature) {
continue;
}

const specUrls = feature.spec.map(url => new URL(url));

if (specUrls.some(specUrl => {
return specUrl.hostname === url.hostname &&
Expand All @@ -71,7 +84,7 @@ function gatherFeaturesFromExplorerUrls(urls) {
}

const candidateId = url.pathname.substring(url.pathname.indexOf("features/") + 9).replace("/", "").replace(".json", "");
if (features[candidateId]) {
if (getFeature(candidateId)) {
gatheredFeatures.add(candidateId);
}
}
Expand All @@ -90,7 +103,7 @@ function gatherFeaturesFromWPTUrls(urls) {

const query = url.searchParams.get("q");
const match = query.match(/feature:([a-z0-9-]+)/);
if (match && match[1] && features[match[1]]) {
if (match && match[1] && getFeature(match[1])) {
gatheredFeatures.add(match[1]);
}
}
Expand All @@ -107,7 +120,7 @@ function gatherFeaturesFromExplicitMentions(issueBody) {
const explicitMentions = issueBody.match(/web-features?:\s*([a-z0-9-]+)/gi) || [];
for (const mention of explicitMentions) {
const match = mention.match(/web-features?:\s*([a-z0-9-]+)/i);
if (match && match[1] && features[match[1]]) {
if (match && match[1] && getFeature(match[1])) {
gatheredFeatures.add(match[1]);
}
}
Expand All @@ -120,7 +133,7 @@ function gatherFeaturesFromExplicitMentions(issueBody) {
for (const section of sectionMentions) {
const lines = section.split(/[\r\n]+/).map(line => line.trim()).filter(line => line && !line.startsWith("###"));
for (const line of lines) {
if (features[line]) {
if (getFeature(line)) {
gatheredFeatures.add(line);
}
}
Expand Down Expand Up @@ -185,27 +198,24 @@ function getDocsAsMarkdown(feature) {
}

function getStandardPositionsAsMarkdown(feature) {
if (!feature.standardPositions.mozilla.url && !feature.standardPositions.webkit.url) {
if (!feature.standardPositions.length) {
return "";
}

const positions = [];

if (feature.standardPositions.mozilla.url) {
positions.push(`[Mozilla](${feature.standardPositions.mozilla.url})`);
}
if (feature.standardPositions.webkit.url) {
positions.push(`[WebKit](${feature.standardPositions.webkit.url})`);
for (const position of feature.standardPositions) {
positions.push(`[${position.vendor}](${position.url})`);
}

return "* **Standard positions:** " + positions.join(", ") + "\n";
}

function getUseCounterAsMarkdown(feature) {
if (!feature.useCounters.chromeStatusUrl) {
if (!feature.chromeUseCounters || !feature.chromeUseCounters.url) {
return "";
}
return `* **Chrome use counter:** [chromestatus.com](${feature.useCounters.chromeStatusUrl})\n`;
return `* **Chrome use counter:** [chromestatus.com](${feature.chromeUseCounters.url})\n`;
}

function getSurveysAsMarkdown(feature) {
Expand All @@ -214,7 +224,7 @@ function getSurveysAsMarkdown(feature) {
}

const surveys = feature.stateOfSurveys.map(survey => {
return `[${survey.name} (${survey.question} question)](${survey.link})`;
return `[${survey.name} (${survey.question} question)](${survey.url})`;
}).join(", ");

return `* **State of CSS/JS/HTML surveys:** ${surveys}\n`;
Expand Down
8 changes: 4 additions & 4 deletions scripts/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"type": "module",
"devDependencies": {
"octokit": "^5.0.3",
"web-features": "^2.48.0",
"web-features": "^3.6.0",
"yargs": "^18.0.0"
}
}