Upgrade to web-features 3.6.0 #1216
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainbrosset
changed the title
foolip
approved these changes
Nov 3, 2025
Member
foolip
left a comment
foolip
left a comment
There was a problem hiding this comment.
This looks like it'll work, handling renames would be nice, but up to you if you feel like it :)
|
|
||
| function getFeature(id) { | ||
| const feature = features[id]; | ||
| if (!feature || feature.kind !== "feature") { |
Member
There was a problem hiding this comment.
Do you see any benefit from handling moved features? It could be done by returning [id, data] perhaps, so that callers that use the ID could use the new one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The web-features bot which we used during the proposal window uses an outdated version of the web-features data library.
This PR upgrades to 3.6.0, which is the latest version of the library, and fixes the code to account for the breaking changes that came with version 3.