-
Notifications
You must be signed in to change notification settings - Fork 292
[Integration]: Add integration with Kserve functionality #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ryan Cook <rcook@redhat.com>
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
Signed-off-by: Ryan Cook <rcook@redhat.com>
Signed-off-by: Ryan Cook <rcook@redhat.com>
Signed-off-by: Ryan Cook <rcook@redhat.com>
Signed-off-by: Ryan Cook <rcook@redhat.com>
Signed-off-by: Ryan Cook <rcook@redhat.com>
Signed-off-by: Ryan Cook <rcook@redhat.com>
|
Signed-off-by: Ryan Cook <rcook@redhat.com>
Signed-off-by: Ryan Cook <rcook@redhat.com>
Signed-off-by: Ryan Cook <rcook@redhat.com>
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: semantic-router-envoy-kserve-config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am not going to block this pr, but can you separate this into 4 sub issues in follow up?
- in k8s, can you change to an gateway instead of a static envoy config, like envoy ai gw (plz refer to https://vllm-semantic-router.com/docs/installation/k8s/ai-gateway) or istio? this can do demo show but in production we need an envoy xds control plane.
- can you later change this guide resources sepecially the semantic router related resources into helm (which we recently supported)
- can you add an integration test after [Feat] Add automate e2e test framework for extensible integration tests #655?
- can you move the docs into website?
|
Thank you for making this happen! |

What type of PR is this?
Allow people to use kserve for the model serving portion when using semantic router
What this PR does / why we need it:
Need to be able to demonstrate this on opendatahub and RHOAI
Which issue(s) this PR fixes:
Fixes #565
Release Notes: Yes