fix lint

Signed-off-by: Ryan Cook <rcook@redhat.com>

Author: cooktheryan

deploy/kserve/README.md

@@ -103,6 +103,14 @@ INFERENCESERVICE_NAME=<your-inferenceservice-name>
 
 # KServe creates a headless service by default (no stable ClusterIP)
 # Create a stable ClusterIP service for consistent routing
+
+# Option 1: Using the template file (recommended)
+# Substitute variables and apply
+sed -e "s/{{INFERENCESERVICE_NAME}}/$INFERENCESERVICE_NAME/g" \
+    -e "s/{{NAMESPACE}}/$NAMESPACE/g" \
+    service-predictor-stable.yaml | oc apply -f - -n $NAMESPACE
+
+# Option 2: Using heredoc
 cat <<EOF | oc apply -f - -n $NAMESPACE
 apiVersion: v1
 kind: Service

deploy/kserve/deploy.sh

@@ -212,7 +212,14 @@ if [ "$SKIP_VALIDATION" = false ]; then
 
     # Create stable ClusterIP service for predictor (KServe creates headless service by default)
     echo "Creating stable ClusterIP service for predictor..."
-    cat <<EOF | oc apply -f - -n "$NAMESPACE" > /dev/null 2>&1
+
+    # Use template file for stable service
+    if [ -f "$SCRIPT_DIR/service-predictor-stable.yaml" ]; then
+        substitute_vars "$SCRIPT_DIR/service-predictor-stable.yaml" "$TEMP_DIR/service-predictor-stable.yaml.tmp"
+        oc apply -f "$TEMP_DIR/service-predictor-stable.yaml.tmp" -n "$NAMESPACE" > /dev/null 2>&1
+    else
+        # Fallback to inline creation if template not found
+        cat <<EOF | oc apply -f - -n "$NAMESPACE" > /dev/null 2>&1
 apiVersion: v1
 kind: Service
 metadata:
@@ -233,6 +240,7 @@ spec:
     targetPort: 8080
     protocol: TCP
 EOF
+    fi
 
     # Get the stable ClusterIP
     PREDICTOR_SERVICE_IP=$(oc get svc "${INFERENCESERVICE_NAME}-predictor-stable" -n "$NAMESPACE" -o jsonpath='{.spec.clusterIP}' 2>/dev/null || echo "")

deploy/kserve/service-predictor-stable.yaml

@@ -3,17 +3,17 @@
 apiVersion: v1
 kind: Service
 metadata:
-  name: {{INFERENCESERVICE_NAME}}-predictor-stable
-  namespace: {{NAMESPACE}}
+  name: "{{INFERENCESERVICE_NAME}}-predictor-stable"
+  namespace: "{{NAMESPACE}}"
   labels:
-    app: {{INFERENCESERVICE_NAME}}
+    app: "{{INFERENCESERVICE_NAME}}"
     component: predictor-stable
   annotations:
     description: "Stable ClusterIP service for semantic router to use (headless service doesn't provide ClusterIP)"
 spec:
   type: ClusterIP
   selector:
-    serving.kserve.io/inferenceservice: {{INFERENCESERVICE_NAME}}
+    serving.kserve.io/inferenceservice: "{{INFERENCESERVICE_NAME}}"
   ports:
   - name: http
     port: 8080