Skip to content

Try agent #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Try agent #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/clickhouseClient.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ describe('clickhouseClient', () => {
inferenceId: 'abc-123',
episodeId: 'episode-123',
pullRequestId: 42,
Comment on lines 34 to 36
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Pass originalPullRequestUrl to createPullRequestToInferenceRecord

The updated tests now call createPullRequestToInferenceRecord without the required originalPullRequestUrl field. The function’s signature still declares this property as mandatory and the implementation inserts it into the ClickHouse payload. As written, the test suite will fail to compile (TypeScript reports a missing property) and, if the calls were compiled with any, the insert would send undefined for original_pull_request_url, contradicting the expectations later in the test. Either the production code needs to infer this URL or the tests must continue to pass it explicitly.

Useful? React with 👍 / 👎.

originalPullRequestUrl: 'https://github.com/org/repo/pull/42'
},
defaultConfig,
{ client }
Expand Down Expand Up @@ -91,7 +90,6 @@ describe('clickhouseClient', () => {
inferenceId: 'abc',
episodeId: 'episode-123',
pullRequestId: 1,
originalPullRequestUrl: 'https://example.com/pr/1'
},
{ ...defaultConfig, table: 'invalid-table!' }
)
Expand All @@ -105,7 +103,6 @@ describe('clickhouseClient', () => {
inferenceId: 'abc',
episodeId: 'episode-123',
pullRequestId: 1,
originalPullRequestUrl: 'https://example.com/pr/1'
},
{ ...defaultConfig, url: ' ' }
)
Expand All @@ -121,7 +118,6 @@ describe('clickhouseClient', () => {
inferenceId: 'abc',
episodeId: 'episode-123',
pullRequestId: 1,
originalPullRequestUrl: 'https://example.com/pr/1'
},
defaultConfig,
{ client }
Expand Down
Loading