Skip to content

Conversation

@shuyangli
Copy link
Member

@shuyangli shuyangli commented Nov 7, 2025

DO NOT MERGE

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 34 to 36
inferenceId: 'abc-123',
episodeId: 'episode-123',
pullRequestId: 42,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Pass originalPullRequestUrl to createPullRequestToInferenceRecord

The updated tests now call createPullRequestToInferenceRecord without the required originalPullRequestUrl field. The function’s signature still declares this property as mandatory and the implementation inserts it into the ClickHouse payload. As written, the test suite will fail to compile (TypeScript reports a missing property) and, if the calls were compiled with any, the insert would send undefined for original_pull_request_url, contradicting the expectations later in the test. Either the production code needs to infer this URL or the tests must continue to pass it explicitly.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants