[Routing] i18n routing. #9515
[Routing] i18n routing. #9515
Conversation
|
I've chosen to use the PHP configurator DSL as the example. I hadn't seen it used previously in the examples. This might be something we'll need to look into in a broader sense. |
|
Status: Needs work |
|
@javiereguiluz the docs for the docs say the PRs get automatically built by platform.sh? Are they published somewhere too? |
|
If this one is merged, should close #9510 |
routing.rst
Outdated
| /** | ||
| * Matches /blog exactly | ||
| * | ||
| * @Route("/blog", name="blog_list") |
There was a problem hiding this comment.
The annotation example look wrong to me. It should have the same routes as the YAML, XML, and PHP examples.
routing.rst
Outdated
| // /blog/2?category=Symfony | ||
|
|
||
| Generating Localized URLs | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
should be stripped to match the length of the headline
| }; | ||
| When a localized route is matched Symfony will automatically know which locale | ||
| should be used during the request. Defining routes this way also eliminated the |
routing.rst
Outdated
| Generating Localized URLs | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| When you've defined localized routes Symfony will use the current request locale |
routing.rst
Outdated
|
|
||
| When you've defined localized routes Symfony will use the current request locale | ||
| as the default when generating routes. In order to generate the route for alternative | ||
| locale you must pass the ``_locale`` in the parameters array:: |
There was a problem hiding this comment.
"for alternative locales" or "for an alternative locale"
|
This paragraph should be removed with this new documentation: http://symfony.com/doc/master/routing.html#translating-routes |
routing.rst
Outdated
| ->controller('App\Controller\CompanyController::about'); | ||
| }; | ||
| When a localized route is matched Symfony will automatically know which locale |
There was a problem hiding this comment.
When a localized route is matched, Symfony will automatically know, which ... and perhaps matches instead of is matched?
javiereguiluz
added
Missing Documentation
Status: Reviewed
and removed
Status: Needs Review
labels
|
Frank, thanks for contributing these docs. Thank you also for implementing this fantastic feature! The community loves it and it's definitely one of the best new features of Symfony 4.1. By the way, congrats on your first Symfony Docs contribution too! |
This PR was merged into the 4.1 branch. Discussion ---------- Removed an outdated section After merging #9515 we forgot to remove this deprecated section, as pointed by @michaelperrin in this comment: #9515 (comment) Commits ------- 00ec943 Removed an outdated section
|
@javiereguiluz thank you! 👍 |
8 participants
No description provided.