Skip to content

[Routing] Add information about internationalized routing #9510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[Routing] Add information about internationalized routing #9510

wants to merge 4 commits into from

Conversation

@dominikhajduk
Copy link
Contributor

@dominikhajduk dominikhajduk commented Mar 28, 2018 •
edited
Loading

@dominikhajduk dominikhajduk changed the title Add information about internationalized routing [Routing] Add information about internationalized routing Mar 28, 2018
@dominikhajduk dominikhajduk mentioned this pull request Mar 28, 2018
Closed
DylanDelobel
DylanDelobel approved these changes Apr 19, 2018
View reviewed changes
Copy link
Contributor

@DylanDelobel DylanDelobel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Symfony best practice recommend using Annotations, the code-block yaml should be after the php-annotations?

xml and php code-block missing, Otherwise, that looks good to me.

@DylanDelobel DylanDelobel mentioned this pull request Apr 19, 2018
Merged
@xabbuh xabbuh added this to the 4.1 milestone Apr 19, 2018
@xabbuh
Copy link
Member

xabbuh commented Apr 19, 2018

Thank you for this PR @dominikhajduk. However I sadly have to close here as #9515 looks more complete. I hope to see you soon again with some other contribution.

@xabbuh xabbuh closed this Apr 19, 2018
@dominikhajduk
Copy link
Contributor Author

dominikhajduk commented Apr 19, 2018

Sure no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@DylanDelobel DylanDelobel DylanDelobel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Status: Needs Review

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

4 participants

@dominikhajduk @xabbuh @DylanDelobel @carsonbot