Skip to content

Conversation

@kaushal-kumar-it
Copy link
Contributor

Resolves #8443.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes C linting errors in the BLAS dasum benchmark files.
  • Replaces uninitialized variable usage and VLA arrays with properly allocated arrays using malloc.
  • Removes unnecessary malloc null checks to comply with stdlib benchmark style.
  • Ensures all benchmark arrays are initialized and freed correctly to avoid warnings and memory leaks.
  • Improves code consistency with other stdlib benchmark files.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution.

N/A


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Nov 8, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 8, 2025

Coverage Report

Package Statements Branches Functions Lines
blas/base/dasum $\color{green}359/359$
$color{green}+100.00%$
$\color{green}17/17$
$color{green}+100.00%$
$\color{green}4/4$
$color{green}+100.00%$
$\color{green}359/359$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Nov 9, 2025
@kgryte
Copy link
Member

kgryte commented Nov 9, 2025

cc @GeoDaoyu as you've made a number of PRs for similar lint errors. Going forward, we'd like to move to dynamic allocation rather than disabling the lint rule.

@kgryte kgryte merged commit ed24f16 into stdlib-js:develop Nov 9, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix C lint errors

3 participants