Skip to content

Conversation

@DivyanshuVortex
Copy link

Resolves #8443.

Description

What is the purpose of this pull request?

This pull request fixes C lint errors in the benchmark.length.c file for the @stdlib/blas/base/dasum package by properly initializing the variable x using dynamic memory allocation.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 8, 2025
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Nov 8, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/base/dasum $\color{green}359/359$
$color{green}+100.00%$
$\color{green}17/17$
$color{green}+100.00%$
$\color{green}4/4$
$color{green}+100.00%$
$\color{green}359/359$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Nov 9, 2025

Ref: #8446

Thank you for opening this PR; however, this PR contains a number of unrelated/undesired changes for resolving the reference upstream issue. For future PRs, it is recommended to be as surgical as possible in the changes which need to be made, as done in the PR referenced above in this comment.

Thank you again for your interest, and we look forward to your future contributions!

@kgryte kgryte closed this Nov 9, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). First-time Contributor A pull request from a contributor who has never previously committed to the project repository.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix C lint errors

3 participants