Skip to content

[iOS] Correctly attach Native gesture #3802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-bert merged 12 commits into from
Nov 13, 2025
Merged

[iOS] Correctly attach Native gesture #3802

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
346036c
Correctly attach NativeViewGestureHandler
m-bert Nov 4, 2025
65bd778
Add view as variable
m-bert Nov 4, 2025
51bdb23
Merge branch 'next' into @mbert/fix-buttons-ios
m-bert Nov 4, 2025
ec06326
Check for protocol
m-bert Nov 4, 2025
a92d664
Use detector view pointer
m-bert Nov 12, 2025
e54c63b
Remove unused import
m-bert Nov 12, 2025
3094904
Keep cleanup in unbindFromView
m-bert Nov 12, 2025
029b77a
Add helper
m-bert Nov 12, 2025
23dafbe
Merge branch 'next' into @mbert/fix-buttons-ios
m-bert Nov 12, 2025
9138f23
Remove unnecessary assignment
m-bert Nov 13, 2025
e5d1666
swap implementations
m-bert Nov 13, 2025
a0ed055
Remove unused implementation
m-bert Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/react-native-gesture-handler/apple/Handlers/RNNativeViewHandler.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,11 @@ - (void)bindToView:(UIView *)view
[control addTarget:self action:@selector(handleDragExit:forEvent:) forControlEvents:UIControlEventTouchDragExit];
[control addTarget:self action:@selector(handleDragEnter:forEvent:) forControlEvents:UIControlEventTouchDragEnter];
[control addTarget:self action:@selector(handleTouchCancel:forEvent:) forControlEvents:UIControlEventTouchCancel];

if (self.actionType == RNGestureHandlerActionTypeNativeDetector) {
[view addGestureRecognizer:_recognizer];
}

} else {
[super bindToView:view];
}
Expand Down
12 changes: 8 additions & 4 deletions packages/react-native-gesture-handler/apple/RNGestureHandler.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,10 +389,14 @@ - (void)sendEventsInState:(RNGestureHandlerState)state

- (RNGHUIView *)findViewForEvents
{
return
[self isKindOfClass:[RNNativeViewGestureHandler class]] && _actionType == RNGestureHandlerActionTypeNativeDetector
? self.recognizer.view.superview
: self.recognizer.view;
if ([self isKindOfClass:[RNNativeViewGestureHandler class]] &&
_actionType == RNGestureHandlerActionTypeNativeDetector) {
RNGHUIView *view = self.recognizer.view.superview;

return [view isKindOfClass:[RCTViewComponentView class]] ? view.superview : view;
}

return self.recognizer.view;
}

- (void)sendEvent:(RNGestureHandlerStateChange *)event
Expand Down
13 changes: 12 additions & 1 deletion packages/react-native-gesture-handler/apple/RNGestureHandlerDetector.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
#import <React/RCTConversions.h>
#import <React/RCTFabricComponentsPlugins.h>

#import "RNGestureHandlerButtonComponentView.h"

#import <react/renderer/components/rngesturehandler_codegen/EventEmitters.h>
#import <react/renderer/components/rngesturehandler_codegen/Props.h>
#import <react/renderer/components/rngesturehandler_codegen/RCTComponentViewHelpers.h>
Expand Down Expand Up @@ -261,9 +263,18 @@ - (void)tryAttachNativeHandlersToChildView
{
RNGestureHandlerManager *handlerManager = [RNGestureHandlerModule handlerManagerForModuleId:_moduleId];

RNGHUIView *view = self.subviews[0];

if ([view isKindOfClass:[RCTViewComponentView class]]) {
RCTViewComponentView *componentView = (RCTViewComponentView *)view;
if (componentView.contentView != nil) {
view = componentView.contentView;
}
}

for (NSNumber *handlerTag in _nativeHandlers) {
[handlerManager.registry attachHandlerWithTag:handlerTag
toView:self.subviews[0]
toView:view
withActionType:RNGestureHandlerActionTypeNativeDetector];

[_attachedHandlers addObject:handlerTag];
Expand Down
Loading