Skip to content

feat: make <a> tags with no href or empty href not treated as links #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2025
Merged

feat: make <a> tags with no href or empty href not treated as links #260

merged 2 commits into from
Nov 20, 2025

Conversation

@szydlovsky
Copy link
Collaborator

@szydlovsky szydlovsky commented Nov 18, 2025 •
edited
Loading

Summary

This PR is an alternative to other PR in here handling iOS crashes due to <a> tag not having href attribute. While the other on e decides to allow empty hrefs as proper links, Android has no such logic. We discussed it a bit with @exploIF and are more eager to go the following way;

  • No href attribute or an empty one => <a> tag not treated as a a link

Test Plan

  • Open iOS example app
  • Input following html either into Set input's value field or into the component's defaultValue prop in App.tsx;
<html>
<p><a href="xd.com">Test2xdd</a></p>
</html>

Should be nicely treated as a link. Now make the href empty or completely remove the attribute from the tag. It should not be treated as a link and a new html won't have an <a> tag in there anymore.

Screenshots / Videos

--

Compatibility

OS Implemented
iOS ✅
Android ✅ (already handled that way)

@szydlovsky szydlovsky requested a review from exploIF November 18, 2025 10:59
@szydlovsky szydlovsky mentioned this pull request Nov 18, 2025
Closed
kacperzolkiewski
kacperzolkiewski reviewed Nov 18, 2025
View reviewed changes
@szydlovsky szydlovsky merged commit 4a51e61 into main Nov 20, 2025
5 checks passed
@szydlovsky szydlovsky deleted the @szydlovsky/no-href-crash-ios branch November 20, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@exploIF exploIF exploIF approved these changes

@kacperzolkiewski kacperzolkiewski kacperzolkiewski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@szydlovsky @exploIF @kacperzolkiewski