feat: make <a> tags with no href or empty href not treated as links (#260)

szydlovsky · web-flow · commit 4a51e61edcf7 · 2025-11-20T13:50:35.000+01:00
# Summary This PR is an alternative to other PR in here handling iOS crashes due to `<a>` tag not having `href` attribute. While the other on e decides to allow empty `hrefs` as proper links, Android has no such logic. We discussed it a bit with @exploIF and are more eager to go the following way; - No `href` attribute or an empty one => `<a>` tag not treated as a a link ## Test Plan - Open iOS example app - Input following html either into `Set input's value` field or into the component's `defaultValue` prop in `App.tsx`; ``` <html> <p><a href="xd.com">Test2xdd</a></p> </html> ``` Should be nicely treated as a link. Now make the href empty or completely remove the attribute from the tag. It should not be treated as a link and a new html won't have an `<a>` tag in there anymore. ## Screenshots / Videos -- ## Compatibility | OS | Implemented | | ------- | :---------: | | iOS | ✅ | | Android | ✅ (already handled that way) |
diff --git a/ios/inputParser/InputParser.mm b/ios/inputParser/InputParser.mm
@@ -610,9 +610,21 @@ - (NSArray *)getTextAndStylesFromHtml:(NSString *)fixedHtml {
     } else if([tagName isEqualToString:@"code"]) {
       [styleArr addObject:@([InlineCodeStyle getStyleType])];
     } else if([tagName isEqualToString:@"a"]) {
+      NSRegularExpression *hrefRegex = [NSRegularExpression regularExpressionWithPattern:@"href=\".+\""
+        options:0
+        error:nullptr
+      ];
+      NSTextCheckingResult* match = [hrefRegex firstMatchInString:params options:0 range: NSMakeRange(0, params.length)];
+      
+      if(match == nullptr) {
+        // same as on Android, no href (or empty href) equals no link style
+        continue;
+      }
+      
+      NSRange hrefRange = match.range;
       [styleArr addObject:@([LinkStyle getStyleType])];
       // cut only the url from the href="..." string
-      NSString *url = [params substringWithRange:NSMakeRange(6, params.length - 7)];
+      NSString *url = [params substringWithRange:NSMakeRange(hrefRange.location + 6, hrefRange.length - 7)];
       stylePair.styleValue = url;
     } else if([tagName isEqualToString:@"mention"]) {
       [styleArr addObject:@([MentionStyle getStyleType])];
@@ -657,7 +669,7 @@ - (NSArray *)getTextAndStylesFromHtml:(NSString *)fixedHtml {
     } else if([tagName isEqualToString:@"blockquote"]) {
       [styleArr addObject:@([BlockQuoteStyle getStyleType])];
     } else {
-    // some other external tags like span just don't get put into the processed styles
+      // some other external tags like span just don't get put into the processed styles
       continue;
     }
     
