Skip to content

Cherrypicks to aio connector part24 - WIF #2594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 12, 2025
Merged

Cherrypicks to aio connector part24 - WIF #2594

merged 15 commits into from
Nov 12, 2025

Conversation

@sfc-gh-pczajka
Copy link
Collaborator

@sfc-gh-pczajka sfc-gh-pczajka commented Oct 23, 2025 •
edited
Loading

DO NOT MERGBE BEFORE:

  • dependency resolved:
    • rebase onto SessnionManager changes (max_retries argument)
    • remove commit starting on "REMOVE"
  • fix test_wif jenkins job

WIF-connected cherry-picks:

@sfc-gh-pczajka sfc-gh-pczajka requested review from a team as code owners October 23, 2025 14:22
@sfc-gh-pczajka sfc-gh-pczajka added the DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector label Oct 23, 2025
@sfc-gh-pczajka sfc-gh-pczajka marked this pull request as draft October 23, 2025 14:22
@sfc-gh-pczajka sfc-gh-pczajka changed the base branch from main to dev/aio-connector October 23, 2025 14:22
@sfc-gh-pczajka sfc-gh-pczajka changed the base branch from dev/aio-connector to cherrypicks-to-aio-connector-part23 October 23, 2025 14:24
Base automatically changed from cherrypicks-to-aio-connector-part23 to dev/aio-connector October 23, 2025 15:00
@sfc-gh-pczajka sfc-gh-pczajka force-pushed the cherrypicks-to-aio-connector-part24 branch 2 times, most recently from 75d33cc to 39c0b34 Compare October 27, 2025 13:12
@sfc-gh-pczajka sfc-gh-pczajka force-pushed the cherrypicks-to-aio-connector-part24 branch from 8b3f685 to 03488c8 Compare October 31, 2025 12:29
sfc-gh-fpawlowski and others added 14 commits November 5, 2025 13:33
@sfc-gh-fpawlowski @sfc-gh-turbaszek
SNOW-2274410: Set no retries for WIF authentication (#2494)
937a8d0
@sfc-gh-pczajka @sfc-gh-turbaszek
[async] Set no retries for WIF authentication (#2494)
1b780d1
@sfc-gh-pczajka @sfc-gh-turbaszek
REMOVE: temp fix begore rebase
0eb706c
@sfc-gh-pmansour @sfc-gh-turbaszek
Update WIF integration tests to verify authenticated username + prepa…
02407d6 
…re for impersonation (#2510)
@sfc-gh-pczajka @sfc-gh-turbaszek
[async] adjust async wif tests (#2510)
a6bc3f4
@sfc-gh-eqin @sfc-gh-pmansour @sfc-gh-turbaszek
Support WIF Impersonation on GCP workloads (#2496)
67861f1 
Co-authored-by: Peter Mansour <peter.mansour@snowflake.com>
@sfc-gh-pczajka @sfc-gh-turbaszek
[async] WIF impersonation for GCP #2496
b7a747b
@sfc-gh-eqin @sfc-gh-pmansour @sfc-gh-turbaszek
Support WIF Impersonation on AWS workloads (#2517)
3843007 
Co-authored-by: Peter Mansour <peter.mansour@snowflake.com>
@sfc-gh-pczajka @sfc-gh-turbaszek
[async] WIF impersonation for AWS (#2517)
4e31410
@sfc-gh-eqin @sfc-gh-turbaszek
Add WIF impersonation path length as data sent to Snowflake backend (#…
feea4cc 
…2521)
@sfc-gh-pczajka @sfc-gh-turbaszek
[async] Add WIF impersonation path length as data sent to Snowflake b…
1102a27 
…ackend (#2521)
@sfc-gh-pczajka @sfc-gh-turbaszek
Fixup test_wif.sh
f5cee6c
@sfc-gh-pczajka @sfc-gh-turbaszek
skip async WIF tests
6948716
@sfc-gh-turbaszek
remove linting issues
5f9d850
@sfc-gh-turbaszek sfc-gh-turbaszek force-pushed the cherrypicks-to-aio-connector-part24 branch from 03488c8 to 5f9d850 Compare November 5, 2025 12:41
@sfc-gh-turbaszek sfc-gh-turbaszek marked this pull request as ready for review November 5, 2025 14:05
sfc-gh-turbaszek
sfc-gh-turbaszek reviewed Nov 5, 2025
View reviewed changes
sfc-gh-fpawlowski
sfc-gh-fpawlowski reviewed Nov 6, 2025
View reviewed changes
sfc-gh-fpawlowski
sfc-gh-fpawlowski reviewed Nov 6, 2025
View reviewed changes
sfc-gh-fpawlowski
sfc-gh-fpawlowski reviewed Nov 6, 2025
View reviewed changes
sfc-gh-fpawlowski
sfc-gh-fpawlowski reviewed Nov 6, 2025
View reviewed changes
@sfc-gh-turbaszek sfc-gh-turbaszek force-pushed the cherrypicks-to-aio-connector-part24 branch from 12e61ac to cc01373 Compare November 6, 2025 14:04
sfc-gh-fpawlowski
sfc-gh-fpawlowski approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-fpawlowski sfc-gh-fpawlowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good 🚢

@sfc-gh-turbaszek sfc-gh-turbaszek merged commit 6b9d691 into dev/aio-connector Nov 12, 2025
49 of 55 checks passed
@sfc-gh-turbaszek sfc-gh-turbaszek deleted the cherrypicks-to-aio-connector-part24 branch November 12, 2025 11:14
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-turbaszek sfc-gh-turbaszek sfc-gh-turbaszek approved these changes

@sfc-gh-fpawlowski sfc-gh-fpawlowski sfc-gh-fpawlowski approved these changes

Assignees

No one assigned

Labels

DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sfc-gh-pczajka @sfc-gh-turbaszek @sfc-gh-fpawlowski @sfc-gh-pmansour @sfc-gh-eqin