Code review

Author: sfc-gh-turbaszek

ci/wif/test_wif.sh

@@ -13,6 +13,5 @@ export RUN_WIF_TESTS=true
 /opt/python/cp312-cp312/bin/python -m pytest test/wif/ --ignore test/wif/test_wif_async.py
 
 # test WIF with asyncio installed
-# /opt/python/cp312-cp312/bin/python -m pip install --break-system-packages -e '.[aio]'
-# run all tests to see whether installation does not break anything
-# /opt/python/cp312-cp312/bin/python -m pytest test/wif/
+ /opt/python/cp312-cp312/bin/python -m pip install --break-system-packages -e '.[aio]'
+ /opt/python/cp312-cp312/bin/python -m pytest test/wif/

src/snowflake/connector/aio/_session_manager.py

@@ -361,7 +361,6 @@ class SessionManager(
     def __init__(
         self,
         config: AioHttpConfig | None = None,
-        max_retries: int | None = None,  # TODO: remove this after rebase
         **http_config_kwargs,
     ) -> None:
         """Create a new async SessionManager."""

src/snowflake/connector/session_manager.py

@@ -387,7 +387,6 @@ class SessionManager(_RequestVerbsUsingSessionMixin, _ConfigDirectAccessMixin):
     def __init__(
         self,
         config: HttpConfig | None = None,
-        max_retries: int | None = None,  # TODO: remove this after rebase
         **http_config_kwargs,
     ) -> None:
         """

test/wif/test_wif_async.py

@@ -28,7 +28,7 @@
 
 
 @pytest.mark.wif
-@pytest.mark.aio
+@pytest.mark.asyncio
 async def test_wif_defined_provider_async():
     connection_params = {
         "host": HOST,
@@ -42,7 +42,7 @@ async def test_wif_defined_provider_async():
 
 
 @pytest.mark.wif
-@pytest.mark.aio
+@pytest.mark.asyncio
 async def test_should_authenticate_using_oidc_async():
     if not is_provider_gcp():
         pytest.skip("Skipping test - not running on GCP")
@@ -61,7 +61,7 @@ async def test_should_authenticate_using_oidc_async():
 
 
 @pytest.mark.wif
-@pytest.mark.aio
+@pytest.mark.asyncio
 async def test_should_authenticate_with_impersonation_async():
     if not isinstance(IMPERSONATION_PATH, str) or not IMPERSONATION_PATH:
         pytest.skip("Skipping test - IMPERSONATION_PATH is not set")