Skip to content

Conversation

@dskloetc
Copy link
Contributor

@dskloetc dskloetc commented Nov 26, 2025

Description

In #4321 we factored adding reverse dependencies into a separate script. To keep the old behavior in get-changeset-arguments.sh we added an intersection with changed packages. But in doing so we forgot to keep outputting all the existing packages.

Changes

Output existing packages from add_changed_reverse_package_deps.

Steps to Test

$ yarn changeset version $(.github/scripts/get-changeset-arguments.sh token-allocation historical-average blocksize-capital finnhub-secondary market-status coinmetrics-lwba coinmarketcap cryptocompare cfbenchmarks tiingo-state tradinghours coinmetrics coinpaprika coingecko finnhub liveart finage tiingo kaiko ncfx)
Not ignoring the following transitive dependencies:
@chainlink/amberdata-adapter
@chainlink/apy-finance-adapter
@chainlink/blocksize-capital-adapter
@chainlink/bsol-price-adapter
@chainlink/cfbenchmarks-adapter
@chainlink/coinapi-adapter
@chainlink/coingecko-adapter
@chainlink/coinmarketcap-adapter
@chainlink/coinmetrics-adapter
@chainlink/coinmetrics-lwba-adapter
@chainlink/coinpaprika-adapter
@chainlink/coinranking-adapter
@chainlink/crypto-volatility-index-adapter
@chainlink/cryptocompare-adapter
@chainlink/curve-3pool-adapter
@chainlink/defi-dozen-adapter
@chainlink/defi-pulse-adapter
@chainlink/dxdao-adapter
@chainlink/ea-bootstrap
@chainlink/ea-factories
@chainlink/ea-reference-data-reader
@chainlink/ea-test-helpers
@chainlink/fcsapi-adapter
@chainlink/finage-adapter
@chainlink/finnhub-adapter
@chainlink/finnhub-secondary-adapter
@chainlink/historical-average-adapter
@chainlink/kaiko-adapter
@chainlink/linear-finance-adapter
@chainlink/liveart-adapter
@chainlink/market-closure-adapter
@chainlink/market-status-adapter
@chainlink/ncfx-adapter
@chainlink/proof-of-reserves-adapter
@chainlink/reduce-adapter
@chainlink/renvm-address-set-adapter
@chainlink/savax-price-adapter
@chainlink/set-token-index-adapter
@chainlink/solana-view-function-adapter
@chainlink/tiingo-adapter
@chainlink/tiingo-state-adapter
@chainlink/token-allocation-adapter
@chainlink/tradinghours-adapter
@chainlink/vesper-adapter
@chainlink/xsushi-price-adapter

Expecting the following packages to be released:
@chainlink/apy-finance-adapter
@chainlink/blocksize-capital-adapter
@chainlink/bsol-price-adapter
@chainlink/cfbenchmarks-adapter
@chainlink/coingecko-adapter
@chainlink/coinmarketcap-adapter
@chainlink/coinmetrics-adapter
@chainlink/coinmetrics-lwba-adapter
@chainlink/coinpaprika-adapter
@chainlink/crypto-volatility-index-adapter
@chainlink/cryptocompare-adapter
@chainlink/curve-3pool-adapter
@chainlink/defi-dozen-adapter
@chainlink/defi-pulse-adapter
@chainlink/dxdao-adapter
@chainlink/finage-adapter
@chainlink/finnhub-adapter
@chainlink/finnhub-secondary-adapter
@chainlink/historical-average-adapter
@chainlink/kaiko-adapter
@chainlink/linear-finance-adapter
@chainlink/liveart-adapter
@chainlink/market-closure-adapter
@chainlink/market-status-adapter
@chainlink/ncfx-adapter
@chainlink/proof-of-reserves-adapter
@chainlink/renvm-address-set-adapter
@chainlink/savax-price-adapter
@chainlink/set-token-index-adapter
@chainlink/tiingo-adapter
@chainlink/tiingo-state-adapter
@chainlink/token-allocation-adapter
@chainlink/tradinghours-adapter
@chainlink/vesper-adapter
@chainlink/xsushi-price-adapter

🦋  All files have been updated. Review them and commit at your leisure

$ git status
On branch kloet/intersect-bug
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	deleted:    .changeset/bright-donuts-leave.md
	deleted:    .changeset/serious-garlics-press.md
	modified:   packages/composites/apy-finance/CHANGELOG.md
	modified:   packages/composites/apy-finance/package.json
	modified:   packages/composites/bsol-price/CHANGELOG.md
	modified:   packages/composites/bsol-price/package.json
	modified:   packages/composites/crypto-volatility-index/CHANGELOG.md
	modified:   packages/composites/crypto-volatility-index/package.json
	modified:   packages/composites/curve-3pool/CHANGELOG.md
	modified:   packages/composites/curve-3pool/package.json
	modified:   packages/composites/defi-dozen/CHANGELOG.md
	modified:   packages/composites/defi-dozen/package.json
	modified:   packages/composites/defi-pulse/CHANGELOG.md
	modified:   packages/composites/defi-pulse/package.json
	modified:   packages/composites/dxdao/CHANGELOG.md
	modified:   packages/composites/dxdao/package.json
	modified:   packages/composites/historical-average/CHANGELOG.md
	modified:   packages/composites/historical-average/package.json
	modified:   packages/composites/linear-finance/CHANGELOG.md
	modified:   packages/composites/linear-finance/package.json
	modified:   packages/composites/market-closure/CHANGELOG.md
	modified:   packages/composites/market-closure/package.json
	modified:   packages/composites/market-status/CHANGELOG.md
	modified:   packages/composites/market-status/package.json
	modified:   packages/composites/proof-of-reserves/CHANGELOG.md
	modified:   packages/composites/proof-of-reserves/package.json
	modified:   packages/composites/savax-price/CHANGELOG.md
	modified:   packages/composites/savax-price/package.json
	modified:   packages/composites/set-token-index/CHANGELOG.md
	modified:   packages/composites/set-token-index/package.json
	modified:   packages/composites/vesper/CHANGELOG.md
	modified:   packages/composites/vesper/package.json
	modified:   packages/composites/xsushi-price/CHANGELOG.md
	modified:   packages/composites/xsushi-price/package.json
	modified:   packages/non-deployable/token-allocation/CHANGELOG.md
	modified:   packages/non-deployable/token-allocation/package.json
	modified:   packages/sources/blocksize-capital/CHANGELOG.md
	modified:   packages/sources/blocksize-capital/package.json
	modified:   packages/sources/cfbenchmarks/CHANGELOG.md
	modified:   packages/sources/cfbenchmarks/package.json
	modified:   packages/sources/coingecko/CHANGELOG.md
	modified:   packages/sources/coingecko/package.json
	modified:   packages/sources/coinmarketcap/CHANGELOG.md
	modified:   packages/sources/coinmarketcap/package.json
	modified:   packages/sources/coinmetrics-lwba/CHANGELOG.md
	modified:   packages/sources/coinmetrics-lwba/package.json
	modified:   packages/sources/coinmetrics/CHANGELOG.md
	modified:   packages/sources/coinmetrics/package.json
	modified:   packages/sources/coinpaprika/CHANGELOG.md
	modified:   packages/sources/coinpaprika/package.json
	modified:   packages/sources/cryptocompare/CHANGELOG.md
	modified:   packages/sources/cryptocompare/package.json
	modified:   packages/sources/finage/CHANGELOG.md
	modified:   packages/sources/finage/package.json
	modified:   packages/sources/finnhub-secondary/CHANGELOG.md
	modified:   packages/sources/finnhub-secondary/package.json
	modified:   packages/sources/finnhub/CHANGELOG.md
	modified:   packages/sources/finnhub/package.json
	modified:   packages/sources/kaiko/CHANGELOG.md
	modified:   packages/sources/kaiko/package.json
	modified:   packages/sources/liveart/CHANGELOG.md
	modified:   packages/sources/liveart/package.json
	modified:   packages/sources/ncfx/CHANGELOG.md
	modified:   packages/sources/ncfx/package.json
	modified:   packages/sources/renvm-address-set/CHANGELOG.md
	modified:   packages/sources/renvm-address-set/package.json
	modified:   packages/sources/tiingo-state/CHANGELOG.md
	modified:   packages/sources/tiingo-state/package.json
	modified:   packages/sources/tiingo/CHANGELOG.md
	modified:   packages/sources/tiingo/package.json
	modified:   packages/sources/tradinghours/CHANGELOG.md
	modified:   packages/sources/tradinghours/package.json

no changes added to commit (use "git add" and/or "git commit -a")

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2025

⚠️ No Changeset found

Latest commit: 3c1225c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

mxiao-cll
mxiao-cll previously approved these changes Nov 26, 2025
@dskloetc dskloetc marked this pull request as ready for review November 26, 2025 15:34
@dskloetc dskloetc enabled auto-merge (squash) November 26, 2025 15:34
@dskloetc dskloetc merged commit b41e530 into main Nov 26, 2025
16 checks passed
@dskloetc dskloetc deleted the kloet/intersect-bug branch November 26, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants