Skip to content

Fix intersect bug in get-changeset-arguments.sh #4329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dskloetc merged 1 commit into from
Nov 26, 2025
Merged

Fix intersect bug in get-changeset-arguments.sh #4329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions .github/scripts/get-changeset-arguments.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,18 @@ intersect() {

add_changed_reverse_package_deps() {
packages="$1"
# We need to include reverse dependencies because if a dependency is
# bumped, this also results in a patch bump of the dependent package.
# But if the dependency is not actually changed (either directly or
# transitively), but only included because of a requirement of
# `changeset version`, we don't want to include it. Otherwise almost all
# packages get included through common dependencies such as
# @chainlink/ea-test-helpers.
intersect "$($SOURCE_DIR/get-reverse-dependencies.sh $packages)" "$CHANGED_PACKAGES_RECURSIVE"
{
# Keep the existing packages.
echo "$packages"
# We need to include reverse dependencies because if a dependency is
# bumped, this also results in a patch bump of the dependent package.
# But if the dependency is not actually changed (either directly or
# transitively), but only included because of a requirement of
# `changeset version`, we don't want to include it. Otherwise almost all
# packages get included through common dependencies such as
# @chainlink/ea-test-helpers.
intersect "$($SOURCE_DIR/get-reverse-dependencies.sh $packages)" "$CHANGED_PACKAGES_RECURSIVE"
} | sort -u
}

add_package_deps() {
Expand Down
Loading