Make list-packages-adapters.sh not follow devDependencies. #4321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #4279 we moved many dependencies of
proof-of-reservestodevDependenciesso that when any of them would be released, we wouldn't have to releaseproof-of-reservesas well.When we created a release for token-balance, indeed
proof-of-reserveswas not included.But the deploy PR did include
proof-of-reserves. This happened becauselist-packages-adapters.sh, which is used bychanged-adapters.shto determine which adapters to deploy, usesyarn workspaces list -R --since. And-Rfollows bothdependenciesanddevDependencies.Changes
get-changeset-arguments.shintoget-reverse-dependencies.sh.get-reverse-dependencies.shinlist-packages-adapters.shto include onlydependenciesand notdevDependencies.add_reverse_package_depsfunction inget-changeset-arguments.shalso had logic only to include changed dependencies. To make this clear it is renamed toadd_changed_reverse_package_depsandintersectis added to keep this behavior as we don't include it inget-reverse-dependencies.sh.get-reverse-dependencies.sh.Steps to Test
data-engineandtoken-balance.glv-tokenis correctly included because it depends ondata-enginebutproof-of-reserves is not included because it only depends ontoken-balanceviadevDependencies`:Quality Assurance
infra-k8sconfiguration file.adapter-secretsconfiguration file.test-payload.jsonfile with relevant requests.feature/x,chore/x,release/x,hotfix/x,fix/x) or is created from Jira.