Backport "Unused lint does not rewrite suppressed warnings" to 3.3 LTS #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
backport-lts-3.3-24055
branch
from
8d53eb4 to
d6cec6d
Compare
tgodzik
force-pushed
the
backport-lts-3.3-22707
branch
from
8e665c4 to
a04d02d
Compare
tgodzik
force-pushed
the
backport-lts-3.3-24055
branch
from
d6cec6d to
8572178
Compare
tgodzik
force-pushed
the
backport-lts-3.3-22707
branch
from
a04d02d to
895a950
Compare
Partially duplicates reporter logic; reporter could auto-apply actions, maybe keying off diagnostic ID.
Instead of testing whether to emit actions by probing suppressions, just let the reporter apply LintWarning actions when the warning is actually reported.
[Cherry-picked 9ec1f84]
tgodzik
force-pushed
the
backport-lts-3.3-24055
branch
from
8572178 to
292c4e1
Compare
tgodzik
force-pushed
the
backport-lts-3.3-24055
branch
from
292c4e1 to
fd8574b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports scala#24055 to the 3.3.7.
PR submitted by the release tooling.