bugfix: Fix null errors after backporting

Author: tgodzik

compiler/src/dotty/tools/dotc/Driver.scala

@@ -92,11 +92,12 @@ class Driver {
           case "help" =>
           case reporterClassName =>
             try
-              Class.forName(reporterClassName).getDeclaredConstructor().newInstance() match
-              case userReporter: Reporter =>
-                ictx.setReporter(userReporter)
-              case badReporter => report.error:
-                em"Not a reporter: ${ctx.settings.Yreporter.value}"
+              val newInstance = Class.forName(reporterClassName).nn.getDeclaredConstructor().nn.newInstance().nn
+              newInstance match
+                case userReporter: Reporter =>
+                  ictx.setReporter(userReporter)
+                case badReporter => report.error:
+                  em"Not a reporter: ${ctx.settings.Yreporter.value}"
             catch case e: ReflectiveOperationException => report.error:
               em"Could not create reporter ${ctx.settings.Yreporter.value}: ${e}"
   }

compiler/src/dotty/tools/dotc/config/ScalaSettings.scala

@@ -377,7 +377,6 @@ private sealed trait YSettings:
   val YdisableFlatCpCaching: Setting[Boolean] = BooleanSetting("-YdisableFlatCpCaching", "Do not cache flat classpath representation of classpath elements from jars across compiler instances.")
 
   val Yscala2Unpickler: Setting[String] = StringSetting("-Yscala2-unpickler", "", "Control where we may get Scala 2 symbols from. This is either \"always\", \"never\", or a classpath.", "always")
-  val YnoReporter: Setting[Boolean] = BooleanSetting("-Yno-reporter", "Diagnostics are silently consumed")
   val Yreporter: Setting[String] = StringSetting(name = "-Yreporter", helpArg = "<class>", descr = "Specify a dotty.tools.dotc.reporting.Reporter", default = "dotty.tools.dotc.reporting.ConsoleReporter")
 
   val YnoImports: Setting[Boolean] = BooleanSetting("-Yno-imports", "Compile without importing scala.*, java.lang.*, or Predef.")

compiler/src/dotty/tools/dotc/interactive/Completion.scala

@@ -576,8 +576,8 @@ object Completion:
               termRef.denot.asSingleDenotation.mapInfo(_ => tpe)
             }
         catch case NonFatal(ex) =>
-          logger.warning(
-            s"Exception when trying to apply extension method:\n ${ex.getMessage()}\n${ex.getStackTrace().mkString("\n")}"
+          logger.nn.warning(
+            s"Exception when trying to apply extension method:\n ${ex.getMessage()}\n${ex.getStackTrace().nn.mkString("\n")}"
           )
           None
 
@@ -684,8 +684,8 @@ object Completion:
       interactiv.println(i"implicit conversion targets considered: ${conversions.toList}%, %")
       conversions
     } catch case NonFatal(ex) =>
-      logger.warning(
-        s"Exception when searching for implicit conversions:\n ${ex.getMessage()}\n${ex.getStackTrace().mkString("\n")}"
+      logger.nn.warning(
+        s"Exception when searching for implicit conversions:\n ${ex.getMessage()}\n${ex.getStackTrace().nn.mkString("\n")}"
       )
       Set.empty
 

compiler/src/dotty/tools/dotc/util/Chars.scala

@@ -137,7 +137,7 @@ object Chars:
 
   def escapedChar(ch: Char): String =
     if requiresFormat(ch) then
-      val b = StringBuilder().append('\'')
+      val b = StringBuilder().append('\'').nn
       escapedChar(b, ch)
       b.append('\'').toString
     else

presentation-compiler/test/dotty/tools/pc/tests/DiagnosticProviderSuite.scala

@@ -32,10 +32,11 @@ class DiagnosticProviderSuite extends PcAssertions {
     additionalChecks: List[Diagnostic] => Unit = identity
   ): Unit =
     val diagnostics = pc
-      .didChange(TestVirtualFileParams(URI.create("file:/Diagnostic.scala"), text))
+      .didChange(TestVirtualFileParams(URI.create("file:/Diagnostic.scala").nn, text))
+      .nn
       .asScala
 
-    val actual = diagnostics.map(d => TestDiagnostic(d.getRange().getStart().getOffset(text), d.getRange().getEnd().getOffset(text), d.getMessage(), d.getSeverity()))
+    val actual = diagnostics.map(d => TestDiagnostic(d.getRange().nn.getStart().nn.getOffset(text), d.getRange().nn.getEnd().nn.getOffset(text), d.getMessage().nn, d.getSeverity().nn))
     assertEquals(expected, actual, s"Expected [${expected.mkString(", ")}] but got [${actual.mkString(", ")}]")
     additionalChecks(diagnostics.toList)
 
@@ -77,8 +78,8 @@ class DiagnosticProviderSuite extends PcAssertions {
       ),
       diags =>
         val action = diags.head.getData().asInstanceOf[java.util.List[CodeAction]].asScala.head
-        assertWithDiff("Remove repeated modifier: \"private\"", action.getTitle(), false)
-        assertEquals(1, action.getEdit().getChanges().size(), "There should be one change")
+        assertWithDiff("Remove repeated modifier: \"private\"", action.getTitle().nn, false)
+        assertEquals(1, action.getEdit().nn.getChanges().nn.size(), "There should be one change")
     )
 
 }