Skip to content

Windows-gnullvm self-contained #147536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Windows-gnullvm self-contained #147536

wants to merge 10 commits into from

Conversation

@mati865
Copy link
Member

@mati865 mati865 commented Oct 9, 2025

No description provided.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 9, 2025
@mati865
Copy link
Member Author

mati865 commented Oct 9, 2025

Tested locally on Windows but a shareable build would be useful.
@bors try jobs=dist-x86_64-linux,dist-x86_64-windows-gnullvm

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Oct 9, 2025
@rust-bors
Auto merge of #147536 - mati865:gnullvm-self-contained, r=<try>
fa81451 
Windows-gnullvm self-contained

try-job: dist-x86_64-linux
try-job: dist-x86_64-windows-gnullvm
@mati865 mati865 mentioned this pull request Oct 9, 2025
Open
@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@rust-bors

This comment was marked as resolved.

Sign in to view
@mati865
Copy link
Member Author

mati865 commented Oct 9, 2025

@bors try jobs=dist-x86_64-linux,dist-x86_64-windows-gnullvm

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Oct 9, 2025
@rust-bors
Auto merge of #147536 - mati865:gnullvm-self-contained, r=<try>
87a3415 
Windows-gnullvm self-contained

try-job: dist-x86_64-linux
try-job: dist-x86_64-windows-gnullvm
@rust-bors
Copy link

rust-bors bot commented Oct 9, 2025

☀️ Try build successful (CI)
Build commit: 87a3415 (87a3415f29207b7d5add0b9bd83328ee459e7843, parent: 0b278a539440be291466ea463a9b6310eaf4d7bb)

mati865
mati865 commented Oct 9, 2025
View reviewed changes
@petrochenkov petrochenkov self-assigned this Oct 10, 2025
@mati865
Copy link
Member Author

mati865 commented Oct 28, 2025

Seems to work nicely, even with -Zbuild-std without having Clang in PATH.
What's left here is a cleanup and reconsideration of what would be the best way to move this forward.

@estebank
Copy link
Contributor

estebank commented Nov 4, 2025

@mati865 are there any blockers we could help you with?

estebank
estebank reviewed Nov 4, 2025
View reviewed changes
compiler/rustc_codegen_ssa/src/back/link.rs Outdated

/// This functions tries to determine the appropriate linker (and corresponding LinkerFlavor) to use
pub fn linker_and_flavor(sess: &Session) -> (PathBuf, LinkerFlavor) {
pub fn linker_and_flavor(sess: &Session, self_contained: bool) -> (PathBuf, LinkerFlavor) {
Copy link
Contributor

@estebank estebank Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make self_contained a new-type? Something like

enum SelfContainedLinkerEnabled {
    Yes,
    No,
}

@mati865
Copy link
Member Author

mati865 commented Nov 5, 2025

@estebank I had a few ideas how to refactor it, but none of them turned out satisfying. I'm going to take another stab at it this week.

@mati865 mati865 force-pushed the gnullvm-self-contained branch from f3f33b7 to 9d27d77 Compare November 10, 2025 20:02
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@mati865 mati865 force-pushed the gnullvm-self-contained branch from 9d27d77 to 9f92112 Compare November 11, 2025 12:45
@bors
Copy link
Collaborator

bors commented Nov 11, 2025

☔ The latest upstream changes (presumably #148818) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estebank estebank estebank left review comments

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mati865 @rust-log-analyzer @estebank @bors @petrochenkov @rustbot