Skip to content

Conversation

@GuillaumeGomez
Copy link
Member

As rightfully detected in #17 (comment) by @thesamesam, this was the wrong source. I updated the hash as well.

@Kobzol
Copy link
Member

Kobzol commented Nov 8, 2025

Could you create a new entry please? We want to document all files in mirrors. The old one will stay there as legacy.

@GuillaumeGomez
Copy link
Member Author

Yeah but the content is wrong. It's not .bz2 and it was never used. Do we want to keep the current invalid one?

@Kobzol
Copy link
Member

Kobzol commented Nov 8, 2025

If it's on the mirrors, it should be in the TOML file. We don't have a way of removing files from mirrors automatically, I think. @pietroalbini ?

marcoieni
marcoieni previously approved these changes Nov 8, 2025
@marcoieni
Copy link
Member

Sorry, approved without reading the comments.

@GuillaumeGomez
Copy link
Member Author

Can it be done manually? :3

@Kobzol
Copy link
Member

Kobzol commented Nov 8, 2025

Yeah, but I'm not sure if it's worth the effort. We have hundreds of legacy and unused files in the mirrors anyway.

@GuillaumeGomez
Copy link
Member Author

Considering it's the same file name, I hope it won't create issues...

@pietroalbini
Copy link
Member

Creating a new file with the same name as an existing file will not work, intentionally. The best option is to call the file something else.

@GuillaumeGomez
Copy link
Member Author

Yeah except we can't do that. It's this file that the script is trying to download, hence why I asked if it's possible to remove it manually because we're kinda stuck here.

@Kobzol
Copy link
Member

Kobzol commented Nov 12, 2025

@marcoieni Could you please remove the previously uploaded file manually?

@marcoieni
Copy link
Member

deleting these two files
image

marcoieni
marcoieni previously approved these changes Nov 12, 2025
Copy link
Member

@marcoieni marcoieni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted the previous files. Merging this PR now

@marcoieni marcoieni enabled auto-merge November 12, 2025 11:03
@GuillaumeGomez
Copy link
Member Author

No no no!

@marcoieni marcoieni disabled auto-merge November 12, 2025 11:04
@marcoieni
Copy link
Member

ok, it should be good now, sorry 😂

@marcoieni marcoieni enabled auto-merge November 12, 2025 11:09
@GuillaumeGomez
Copy link
Member Author

I confirm it is. Needed to revert to the original state of the PR. :)

@marcoieni marcoieni added this pull request to the merge queue Nov 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2025
@GuillaumeGomez
Copy link
Member Author

Network flakyness issue? The URL does download the file for me.

@marcoieni marcoieni added this pull request to the merge queue Nov 12, 2025
@marcoieni
Copy link
Member

works for me too, let's see..

Merged via the queue into rust-lang:main with commit 6a784c4 Nov 12, 2025
3 checks passed
@GuillaumeGomez GuillaumeGomez deleted the fix-gmp-source branch November 12, 2025 11:29
@GuillaumeGomez
Copy link
Member Author

Dark magic. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants