Add new rename-from field to ensure checks when source URL file differs from name
#22
+100
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
reviewed
Nov 16, 2025
Member
Kobzol
left a comment
Kobzol
left a comment
There was a problem hiding this comment.
Looks great, thanks. Left one comment + could you please document the new field in the README?
| && path_name != file_name | ||
| { | ||
| match mirror_file.rename_from { | ||
| Some(ref rename_from) => { |
Member
There was a problem hiding this comment.
If I do something like this:
[[files]]
name = "rustc/llvm-mingw-20251104-ucrt-x86_64.zip"
sha256 = "171b298f46fa4b5653dc7b01cc5e709caca645991be8e1b0724466c4a282a1ac"
source = "https://github.com/mstorsjo/llvm-mingw/releases/download/20251104/llvm-mingw-20251104-ucrt-x86_64.zip"
license = "Apache License v2.0 with LLVM Exceptions"
rename-from = "foo"Then there's no error. It would be great to also validate that rename-from isn't used if the filenames actually match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to avoid situations like #17 / #18 to happen again as discussed on zulip.
cc @Kobzol @marcoieni