fix docs for new clippy lint #740
Conversation
|
Concept ACK but it also fails CI. :) |
|
strace shows that xargo is failing trying to access some internal lockfile: Looks to me like xargo is just broken and I need to revert the update to the nightly compiler. |
secp256k1-sys/src/lib.rs
Outdated
| /// If you create one of these with `secp256k1_context_create` you must | ||
| /// destroy it with `secp256k1_context_destroy`. (Failure to destroy it is | ||
| /// a memory leak; destroying it using any other allocator is likely to be | ||
| /// undefined behavior.) |
There was a problem hiding this comment.
I'd just write "is undefined behavior". I don't think it's useful to try to define some crazy circumstances when it's not.
| /// secret key passed to `ElligatorSwift::shared_secret`. | ||
| /// Represents which party we are in the ECDH. | ||
| /// | ||
| /// Here `A` is the initiator and `B` is the responder. |
There was a problem hiding this comment.
I guess we should've named the enum variants as such. :(
| /// of being zero, overflowing the group order, or equalling any specific value. | ||
| /// | ||
| /// Since version 0.29 this has been deprecated; users should instead implement | ||
| /// `Into<Message>` for types that satisfy these properties. |
There was a problem hiding this comment.
I wonder when are we going to remove this entirely.
There was a problem hiding this comment.
It was deprecated in April. Let's give it at least a year (unless it winds up blocking 1.0). I'd give it 2. It's self-contained and not hurting anything.
|
Yeah -- I believe this is fixed upstream by rust-lang/cargo#14370 so we just need to wait. Meanwhile I'll revert the nightly update. |
|
That issue says august 8th. |
|
Yes. How long is the delay between stuff getting merged into cargo and it showing up in a rustc nightly? I have no idea. |
IIUC it's should be the following night - hence the name "nightly" |
|
I think that only applies to |
|
Reminder to me to merge #737 after this gets in |
|
Do you want to address my comments? |
There are a bunch of doccomments whose first lines are (much) too long. Most of these are also difficult to understand and/or out-of-date. Just rewrite them all.
This reverts commit 78d93b7.
apoelstra
force-pushed
the
2024-09--fix-docs
branch
from
9e08c87 to
3810686
Compare
|
Sure. Removed "likely to be" from the UB comment. Should be good to go now. |
38106866c1c23ea2c76879cae2332ea80064711a Revert "Automated update to Github CI to rustc nightly-2024-09-10" (Andrew Poelstra)
d3d9a050a7c87807f6ccc978e8bf8bb2a8764f0b fix docs for new clippy lint. (Andrew Poelstra)
Pull request description:
There are a bunch of doccomments whose first lines are (much) too long. Most of these are also difficult to understand and/or out-of-date. Just rewrite them all.
ACKs for top commit:
Kixunil:
ACK 38106866c1c23ea2c76879cae2332ea80064711a
Tree-SHA512: 291bd2c30c8d46c54d99eba17b6cc5f018912b906f4395fa753218551c1ba50724bdd55699f12bf9de254debf9612541c47e1fcd9c2eb04784f71c21e94b5ea5
38106866c1c23ea2c76879cae2332ea80064711a Revert "Automated update to Github CI to rustc nightly-2024-09-10" (Andrew Poelstra)
d3d9a050a7c87807f6ccc978e8bf8bb2a8764f0b fix docs for new clippy lint. (Andrew Poelstra)
Pull request description:
There are a bunch of doccomments whose first lines are (much) too long. Most of these are also difficult to understand and/or out-of-date. Just rewrite them all.
ACKs for top commit:
Kixunil:
ACK 38106866c1c23ea2c76879cae2332ea80064711a
Tree-SHA512: 291bd2c30c8d46c54d99eba17b6cc5f018912b906f4395fa753218551c1ba50724bdd55699f12bf9de254debf9612541c47e1fcd9c2eb04784f71c21e94b5ea5
2 participants
There are a bunch of doccomments whose first lines are (much) too long. Most of these are also difficult to understand and/or out-of-date. Just rewrite them all.