Skip to content

Conversation

@tcharding
Copy link
Member

Currently we run the job at midnight here and in bitcoin, this led recently to one using the nightly toolchain from the 10th of Sep and the other using the toolchain from 11th of Sep.

Update to run at 5 past so this doesn't happen again.

@tcharding
Copy link
Member Author

Also done in rust-bitcoin/rust-bitcoin#3351

Kixunil
Kixunil previously approved these changes Sep 12, 2024
Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 300daef

@apoelstra
Copy link
Member

Lol, I can't test anything on this repo because clippy is failing with the nightly-version that is committed since #738

I can disable clippy for now but I think instead we should fix the issue so that we don't have red Xs on everything.

@apoelstra
Copy link
Member

Needs #740.

@tcharding
Copy link
Member Author

tcharding commented Sep 12, 2024

that is committed since #738

Bollocks, hard to get good help huh :)

Currently we run the job at midnight here and in `bitcoin`, this led
recently to one using the nightly toolchain from the 10th of Sep and the
other using the toolchain from 11th of Sep.

Update to run at 5 past so this doesn't happen again.
@tcharding
Copy link
Member Author

Rebased. Added mention of UTC while I was at it.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 624fd47 successfully ran local tests

@apoelstra apoelstra merged commit d042094 into rust-bitcoin:master Sep 12, 2024
chain-forgexcr45 added a commit to chain-forgexcr45/rust-secp256k1 that referenced this pull request Sep 28, 2025
… at 5 past midnight

624fd47574484827c269f7779005939761c6047a CI: Run the nightly update job at 5 past midnight (Tobin C. Harding)

Pull request description:

  Currently we run the job at midnight here and in `bitcoin`, this led recently to one using the nightly toolchain from the 10th of Sep and the other using the toolchain from 11th of Sep.

  Update to run at 5 past so this doesn't happen again.

ACKs for top commit:
  apoelstra:
    ACK 624fd47574484827c269f7779005939761c6047a successfully ran local tests

Tree-SHA512: 6fe9a4e2d6c3c04c962f99611f3536a99787393214402a0de2632eb867271560744b842c633c5318281f6e40ad848d42a88bfe6a7f393d19d8601d8e67590620
william2332-limf added a commit to william2332-limf/rust-secp256k1 that referenced this pull request Oct 2, 2025
… at 5 past midnight

624fd47574484827c269f7779005939761c6047a CI: Run the nightly update job at 5 past midnight (Tobin C. Harding)

Pull request description:

  Currently we run the job at midnight here and in `bitcoin`, this led recently to one using the nightly toolchain from the 10th of Sep and the other using the toolchain from 11th of Sep.

  Update to run at 5 past so this doesn't happen again.

ACKs for top commit:
  apoelstra:
    ACK 624fd47574484827c269f7779005939761c6047a successfully ran local tests

Tree-SHA512: 6fe9a4e2d6c3c04c962f99611f3536a99787393214402a0de2632eb867271560744b842c633c5318281f6e40ad848d42a88bfe6a7f393d19d8601d8e67590620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants