-
Notifications
You must be signed in to change notification settings - Fork 306
CI: Run the nightly update job at 5 past midnight #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Also done in rust-bitcoin/rust-bitcoin#3351 |
Kixunil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 300daef
|
Lol, I can't test anything on this repo because clippy is failing with the I can disable clippy for now but I think instead we should fix the issue so that we don't have red Xs on everything. |
|
Needs #740. |
Bollocks, hard to get good help huh :) |
Currently we run the job at midnight here and in `bitcoin`, this led recently to one using the nightly toolchain from the 10th of Sep and the other using the toolchain from 11th of Sep. Update to run at 5 past so this doesn't happen again.
300daef to
624fd47
Compare
|
Rebased. Added mention of UTC while I was at it. |
apoelstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 624fd47 successfully ran local tests
… at 5 past midnight
624fd47574484827c269f7779005939761c6047a CI: Run the nightly update job at 5 past midnight (Tobin C. Harding)
Pull request description:
Currently we run the job at midnight here and in `bitcoin`, this led recently to one using the nightly toolchain from the 10th of Sep and the other using the toolchain from 11th of Sep.
Update to run at 5 past so this doesn't happen again.
ACKs for top commit:
apoelstra:
ACK 624fd47574484827c269f7779005939761c6047a successfully ran local tests
Tree-SHA512: 6fe9a4e2d6c3c04c962f99611f3536a99787393214402a0de2632eb867271560744b842c633c5318281f6e40ad848d42a88bfe6a7f393d19d8601d8e67590620
… at 5 past midnight
624fd47574484827c269f7779005939761c6047a CI: Run the nightly update job at 5 past midnight (Tobin C. Harding)
Pull request description:
Currently we run the job at midnight here and in `bitcoin`, this led recently to one using the nightly toolchain from the 10th of Sep and the other using the toolchain from 11th of Sep.
Update to run at 5 past so this doesn't happen again.
ACKs for top commit:
apoelstra:
ACK 624fd47574484827c269f7779005939761c6047a successfully ran local tests
Tree-SHA512: 6fe9a4e2d6c3c04c962f99611f3536a99787393214402a0de2632eb867271560744b842c633c5318281f6e40ad848d42a88bfe6a7f393d19d8601d8e67590620
Currently we run the job at midnight here and in
bitcoin, this led recently to one using the nightly toolchain from the 10th of Sep and the other using the toolchain from 11th of Sep.Update to run at 5 past so this doesn't happen again.