Skip to content

Conversation

@thedevmystic
Copy link
Contributor

Hello, respected maintainers, and reviewers!!
Again, this is Surya :)

This follow-up PR on interpolation_methods.hpp, cleans up the deprecated InterpolationMethodMap, for the next release cycle.

This PR addresses,

  1. Removed deprecated InterpolationMethodMap.

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.91%. Comparing base (36cfca8) to head (1abfeb0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2041   +/-   ##
=======================================
  Coverage   84.91%   84.91%           
=======================================
  Files         148      148           
  Lines       14367    14367           
  Branches     1230     1230           
=======================================
  Hits        12200    12200           
  Misses       1740     1740           
  Partials      427      427           
Flag Coverage Δ
unittests 84.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nt_trajectory_controller/interpolation_methods.hpp 23.52% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich added the hold Holding off merging this PR until some condition label Dec 2, 2025
@christophfroehlich christophfroehlich changed the title Cleaned the deprecated InterpolationMethodMap. Cleanup deprecated InterpolationMethodMap Dec 2, 2025
Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself seems fine, but what is the policy on deprecating this? Having only one sync in between seems less than what we used to do previously.

@saikishor
Copy link
Member

The change itself seems fine, but what is the policy on deprecating this? Having only one sync in between seems less than what we used to do previously.

Yes, we will have to hold it for sometime

@thedevmystic
Copy link
Contributor Author

Yes, I also think so. We should wait few release syncs before cleaning it up. 👍

@christophfroehlich
Copy link
Member

Yes, that's why I labeled it as hold but will likely merge it once the deprecation got synced.
I'm just annoyed by the deprecation warning we have now, see #2019 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold Holding off merging this PR until some condition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants