Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
1836341
fix(basic-1.1, 2.1 and 3.7):adjust identation for html and css and ad…
Amrillo Oct 13, 2025
e8ea638
fix(basic-1.3): add double quotes instead of single quotes for HTML a…
Amrillo Oct 13, 2025
fb2fa44
fix(basic-1.2): change HTML-tags, attributes and their values, CSS se…
Amrillo Oct 13, 2025
d2d574b
fix(basic-2.2):add tag DOCTYPE html
Amrillo Oct 13, 2025
1f43284
fix(basic-2.4): remove 'type' attribute
Amrillo Oct 13, 2025
e16514d
fix(basic-1.3):add double quotes instead of single quotes for HTML at…
Amrillo Oct 13, 2025
9597b2d
refactor(extended-1.1): add proper semantics to the html tags
Amrillo Oct 13, 2025
d805793
fix(basic-3.2,3.4): remove some tag selectors and give the meaningful…
Amrillo Oct 15, 2025
7f2ba85
fix(basic-3.1): use single style for selectors naming
Amrillo Oct 15, 2025
b5dd60a
fix(basic-3.3,3.1): keep the name of identifiers concise and keep a s…
Amrillo Oct 15, 2025
74faae1
fix(basic-3.8):separate selectors and properties
Amrillo Oct 15, 2025
77ae498
fix(basic-3.6): put space after property name
Amrillo Oct 15, 2025
c29ad71
fix(basic-3.3):remove extra clasess to keep the styling short and con…
Amrillo Oct 15, 2025
4450bd8
refactor(extended-1.1): change label tag to h3 tag to improve semantics
Amrillo Oct 15, 2025
2ac7670
fix(basic-3.1,3.4): remove tag selectors and keep single styling for …
Amrillo Oct 15, 2025
715f621
fix(basic-3.4): change tag selectors to classes
Amrillo Oct 15, 2025
aecb99b
fix(no-rule): add classes to tag elements and add classname in app.js…
Amrillo Oct 15, 2025
ede1522
fix(basic-3.2): give the meaningfull name for classes
Amrillo Oct 15, 2025
84fe3b9
fix(basic-3.4): remove tag selectors from styling replacing with clasess
Amrillo Oct 15, 2025
d781547
fix(no-rule): make some changes due to the removing tag selector
Amrillo Oct 15, 2025
eeecbd7
fix(basic-3.4): remove tag selectors from styling replacing with clasess
Amrillo Oct 15, 2025
f7b68b3
fix(no-rule): make some changes due to the removing tag selector
Amrillo Oct 15, 2025
8a962f2
fix(basic-1.3):add double quotes
Amrillo Oct 15, 2025
eb7dc25
refactor(basic-2.5): break long lines into multiple to improve code r…
Amrillo Oct 15, 2025
e14473c
fix(basic-2.3): remove named characters
Amrillo Oct 15, 2025
6515e9d
refactor(extended-1.2): add alt attributes for img tags for accessibi…
Amrillo Oct 16, 2025
1046c2a
fix(basic-3.4,3.1): remove tag selectors and add single styling for c…
Amrillo Oct 16, 2025
03930bc
fix(no-rule): make adjustment in html layout due to the changes in st…
Amrillo Oct 16, 2025
ae1732f
fix(basic-3.4,3.1): remove tag selectors and add single styling for c…
Amrillo Oct 16, 2025
d277108
fix(no-rule): make adjustment in html layout and app.js due to the ch…
Amrillo Oct 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions app.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

var taskInput=document.getElementById("new-task");//Add a new task.
var addButton=document.getElementsByTagName("button")[0];//first button
var incompleteTaskHolder=document.getElementById("incompleteTasks");//ul of #incompleteTasks
var incompleteTaskHolder=document.getElementById("incomplete-tasks");//ul of #incompleteTasks
var completedTasksHolder=document.getElementById("completed-tasks");//completed-tasks


Expand All @@ -31,20 +31,23 @@ var createNewTaskElement=function(taskString){
//button.delete
var deleteButton=document.createElement("button");//delete button
var deleteButtonImg=document.createElement("img");//delete button image
listItem.className='todo-item';

label.innerText=taskString;
label.className='task';
label.className='todo-task completed-label edit-mode-label';

//Each elements, needs appending
checkBox.type="checkbox";
checkBox.type = "checkbox";
checkBox.className = 'todo-item-checkbox';
editInput.type="text";
editInput.className="task";
editInput.className="todo-task input-task";

editButton.innerText="Edit"; //innerText encodes special characters, HTML does not.
editButton.className="edit";
editButton.className="btn edit";

deleteButton.className="delete";
deleteButtonImg.src='./remove.svg';
deleteButton.className="btn delete";
deleteButtonImg.src = './remove.svg';
deleteButtonImg.className = 'remove-icon';
deleteButton.appendChild(deleteButtonImg);


Expand Down Expand Up @@ -84,22 +87,24 @@ var editTask=function(){

var editInput=listItem.querySelector('input[type=text]');
var label=listItem.querySelector("label");
var editBtn=listItem.querySelector(".edit");
var containsClass=listItem.classList.contains("editMode");
var editBtn=listItem.querySelector(".btn.edit");
var containsClass=listItem.classList.contains("edit-mode");
//If class of the parent is .editmode
if(containsClass){

//switch to .editmode
//label becomes the inputs value.
label.innerText=editInput.value;
label.innerText = editInput.value;
// label.classList.add('edit-mode-label');
editBtn.innerText="Edit";
}else{
editInput.value=label.innerText;
editInput.value = label.innerText;
// label.classList.remove('edit-mode-label');
editBtn.innerText="Save";
}

//toggle .editmode on the parent.
listItem.classList.toggle("editMode");
listItem.classList.toggle("edit-mode");
};


Expand Down Expand Up @@ -156,8 +161,8 @@ var bindTaskEvents=function(taskListItem,checkBoxEventHandler){
console.log("bind list item events");
//select ListItems children
var checkBox=taskListItem.querySelector("input[type=checkbox]");
var editButton=taskListItem.querySelector("button.edit");
var deleteButton=taskListItem.querySelector("button.delete");
var editButton=taskListItem.querySelector(".btn.edit");
var deleteButton=taskListItem.querySelector(".btn.delete");


//Bind editTask to edit button.
Expand Down
103 changes: 85 additions & 18 deletions index.html
Original file line number Diff line number Diff line change
@@ -1,19 +1,86 @@
<!DOCTYPE html>
<html>
<HEAD><title>Todo App</title>
<link href='https://fonts.googleapis.com/css?family=Lato:300,400,700' rel='stylesheet' type='text/css'>
<link rel="stylesheet" href="style.css" type="text/css" MEDIA="screen" charset="utf-8">
</HEAD>
<body>
<div class="aaa"><img src="./eisenhower-matrix.jpg"><a class='more_inf' href="https://goal-life.com/page/method/matrix-eisenhower">Want more details&quest;</a></div>
<div class="centered-main-page-element"><p id='topSectionForAddingElementToList'><label for="new-task">Add Item</label><div class="task-row-wrapper"><input id='new-task'class="task" type="text"><button>Add</button></div>
</p><h3>Todo</h3>
<ul id='incompleteTasks'>
<li><input type='checkbox'><label class="task">Pay Bills</label><input type="text" class="task"><button class="edit">Edit</button><button class="delete"><img src="./remove.svg"></button></li>
<li class="editMode"><input type="checkbox"><label class="task">Go Shopping</label><input type="text" value="Go Shopping" class="task"><button class='edit'>Save</button><button class="delete"><img src="./remove.svg"></button></li>
</ul><h3>Completed</h3><ul id="completed-tasks"><li><input type="checkbox" checked><label class="task">See the Doctor</label><input type="text" class="task"><button class="edit">Edit</button><button class="delete"><img src="./remove.svg"></button>
</li>
</ul>
</div>
<script type="text/javascript" SRC="app.js"></script>
</body>
</html>
<head>
<title>Todo App</title>
<link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Lato:300,400,700" >
<link rel="stylesheet" href="style.css">
</head>
<body class="page">
<header class="header">
<img src="./eisenhower-matrix.jpg" alt="logo picture">
<a
class="more-inf"
href="https://goal-life.com/page/method/matrix-eisenhower">
Want more details?
</a>
</header>
<main class="main-wrapper">
<section id="add-todo">
<h3 class="todo-title">Add Item</h3>
<div class="task-row-wrapper">
<input
id="new-task"
class="todo-task input-task"
type="text">
<button class="btn">Add</button>
</div>
</section>
<section>
<h3 class="todo-title">Todo</h3>
<ul id="incomplete-tasks">
<li class="todo-item">
<input type="checkbox" class="todo-item-checkbox">
<label class="todo-task completed-label edit-mode-label">Pay Bills</label>
<input
type="text"
class="todo-task input-task">
<button class="btn edit">Edit</button>
<button class="btn delete">
<img
src="./remove.svg"
alt="close icon"
class="remove-icon">
</button>
</li>
<li class="todo-item edit-mode">
<input type="checkbox" class="todo-item-checkbox">
<label class="todo-task completed-label edit-mode-label">Go Shopping</label>
<input
type="text"
value="Go Shopping"
class="todo-task input-task">
<button class="btn edit">Save</button>
<button class="btn delete">
<img src="./remove.svg" alt="close icon" class="remove-icon">
</button>
</li>
</ul>
</section>
<section>
<h3 class="todo-title">Completed</h3>
<ul id="completed-tasks">
<li class="todo-item">
<input
type="checkbox"
checked
class="todo-item-checkbox">
<label class="todo-task completed-label edit-mode-label">See the Doctor</label>
<input
type="text"
class="todo-task input-task">
<button class="btn edit">Edit</button>
<button class="btn delete">
<img
src="./remove.svg"
alt="close icon"
class="remove-icon">
</button>
</li>
</ul>
</section>
</main>
<script src="app.js"></script>
</body>
</html>


Loading