Skip to content

Task "Clean Code S1E1" #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Task "Clean Code S1E1" #148

wants to merge 30 commits into from

Conversation

@Amrillo
Copy link

@Amrillo Amrillo commented Oct 16, 2025 •
edited
Loading

  1. Task: https://github.com/rolling-scopes-school/tasks/blob/master/stage1/modules/clean-code/clean-code-s1e1.md
  2. Screenshot:
image
  1. Deploy: Task "Clean Code S1E1" #148
  2. Done 16.10.2025 / deadline 21.10.2025
  3. Score: 40 / 45
  • 2 points for each of 15 list items for beginner guidline: 30
  • 5 points for each of 2 list items for advanced guidline : 10

Amrillo added 30 commits October 13, 2025 15:35
@Amrillo
fix(basic-1.1, 2.1 and 3.7):adjust identation for html and css and ad…
1836341 
…d semicolon after properties in css
@Amrillo
fix(basic-1.3): add double quotes instead of single quotes for HTML a…
e8ea638 
…ttributes and CSS properties
@Amrillo
fix(basic-1.2): change HTML-tags, attributes and their values, CSS se…
fb2fa44 
…lectors, CSS properties and their values to lowercase
@Amrillo
fix(basic-2.2):add tag DOCTYPE html
d2d574b
@Amrillo
fix(basic-2.4): remove 'type' attribute
1f43284
@Amrillo
fix(basic-1.3):add double quotes instead of single quotes for HTML at…
e16514d 
…tributes and CSS properties
@Amrillo
refactor(extended-1.1): add proper semantics to the html tags
9597b2d
@Amrillo
fix(basic-3.2,3.4): remove some tag selectors and give the meaningful…
d805793 
…l name for classes and identifiers
@Amrillo
fix(basic-3.1): use single style for selectors naming
7f2ba85
@Amrillo
fix(basic-3.3,3.1): keep the name of identifiers concise and keep a s…
b5dd60a 
…ingle styling
@Amrillo
fix(basic-3.8):separate selectors and properties
74faae1
@Amrillo
fix(basic-3.6): put space after property name
77ae498
@Amrillo
fix(basic-3.3):remove extra clasess to keep the styling short and con…
c29ad71 
…cise
@Amrillo
refactor(extended-1.1): change label tag to h3 tag to improve semantics
4450bd8
@Amrillo
fix(basic-3.1,3.4): remove tag selectors and keep single styling for …
2ac7670 
…classes
@Amrillo
fix(basic-3.4): change tag selectors to classes
715f621
@Amrillo
fix(no-rule): add classes to tag elements and add classname in app.js…
aecb99b 
… due to the adjustment in styling
@Amrillo
fix(basic-3.2): give the meaningfull name for classes
ede1522
@Amrillo
fix(basic-3.4): remove tag selectors from styling replacing with clasess
84fe3b9
@Amrillo
fix(no-rule): make some changes due to the removing tag selector
d781547
@Amrillo
fix(basic-3.4): remove tag selectors from styling replacing with clasess
eeecbd7
@Amrillo
fix(no-rule): make some changes due to the removing tag selector
f7b68b3
@Amrillo
fix(basic-1.3):add double quotes
8a962f2
@Amrillo
refactor(basic-2.5): break long lines into multiple to improve code r…
eb7dc25 
…eadibility
@Amrillo
fix(basic-2.3): remove named characters
e14473c
@Amrillo
refactor(extended-1.2): add alt attributes for img tags for accessibi…
6515e9d 
…lity
@Amrillo
fix(basic-3.4,3.1): remove tag selectors and add single styling for c…
1046c2a 
…lasses
@Amrillo
fix(no-rule): make adjustment in html layout due to the changes in st…
03930bc 
…yling
@Amrillo
fix(basic-3.4,3.1): remove tag selectors and add single styling for c…
ae1732f 
…lasses
@Amrillo
fix(no-rule): make adjustment in html layout and app.js due to the ch…
d277108 
…anges in styling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Amrillo