Skip to content

fix(rivetkit): fix onError handler not working #3455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 11-09-chore_site_tweak_wording
Choose a base branch
from
+4 −11
Open

fix(rivetkit): fix onError handler not working #3455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rivetkit-typescript/packages/rivetkit/src/registry/mod.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ export class Registry<A extends RegistryActors> {
// Start server
if (!config.disableDefaultServer) {
const serverPromise = (async () => {
const out = await crossPlatformServe(config, hono, undefined);
const out = await crossPlatformServe(config, hono);
upgradeWebSocket = out.upgradeWebSocket;
})();
readyPromises.push(serverPromise);
Expand Down
13 changes: 3 additions & 10 deletions rivetkit-typescript/packages/rivetkit/src/registry/serve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
import { Hono } from "hono";
import type { Hono } from "hono";
import { logger } from "./log";
import type { RunnerConfig } from "./run-config";

export async function crossPlatformServe(
runConfig: RunnerConfig,
rivetKitRouter: Hono<any>,
userRouter: Hono | undefined,
app: Hono<any>,
) {
const app = userRouter ?? new Hono();

// Import @hono/node-server using string variable to prevent static analysis
const nodeServerModule = "@hono/node-server";
let serve: any;
Expand All @@ -25,10 +22,6 @@ export async function crossPlatformServe(
process.exit(1);
}

// Mount registry
// app.route("/registry", rivetKitRouter);
app.route("/", rivetKitRouter);

// Import @hono/node-ws using string variable to prevent static analysis
const nodeWsModule = "@hono/node-ws";
let createNodeWebSocket: any;
Expand All @@ -47,7 +40,7 @@ export async function crossPlatformServe(

// Inject WS
const { injectWebSocket, upgradeWebSocket } = createNodeWebSocket({
app,
app: app,
});

// Start server
Expand Down
Loading