Skip to content

Conversation

@datho7561
Copy link
Contributor

What does this PR do?

Rebases #396

What issues does this PR fix or reference?

#244

Is it tested? How?

Through unit tests. It can't be tested in VS Code due to microsoft/vscode#247651 . It should be possible to test this in a different language client (perhaps Neovim, Helix, or Eclipse); I'll try that and update this PR accordingly.

@coveralls
Copy link

Coverage Status

coverage: 84.195% (+0.02%) from 84.178%
when pulling f03bb1d on datho7561:convert-tab-to-spaces
into 2a2e614 on redhat-developer:main.

@mickaelistria
Copy link
Contributor

Any chance for this to be merged?

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 force-pushed the convert-tab-to-spaces branch from 8e62ec0 to ea73241 Compare November 10, 2025 14:09
@datho7561
Copy link
Contributor Author

@mickaelistria I've rebased the PR. I haven't had a chance to manually test this in WildWebDeveloper, do you know how to setup WildWebDeveloper to use this PR so I can test it? I guess I could merge this untested, but that doesn't sound helpful.

@datho7561 datho7561 moved this to In Progress in Java Tooling Nov 10, 2025
@mickaelistria
Copy link
Contributor

I think the "simplest" way to test it would require importing Wild Web Developer in your workspace;
Then npm install yaml-language-server with your change so it's available locally for future resolutions.
Then tweak the package.json in wildwebdeveloper to get your version of yaml-language-server used.
And mvn verify on org.eclipse.wildwebdeveloper
Then you should be able to Run As > Eclipse application and get Wild Web Developer using your yaml-language-server.

@datho7561
Copy link
Contributor Author

Okay, thanks, I'll try this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

4 participants